third_party/yasm/README.chromium - Issue 693943003: Update from https://crrev.com/302630

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/yasm/README.chromium

Issue 693943003: Update from https://crrev.com/302630 (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/protobuf/src/google/protobuf/unknown_field_set.h ('k') | third_party/yasm/yasm.gyp » ('j') | no next file with comments »

OLD	NEW
1 Name: yasm	1 Name: yasm

2 URL: http://www.tortall.net/projects/yasm/	2 URL: http://www.tortall.net/projects/yasm/

3 Version: 1.2.0	3 Version: 1.2.0

4 License: 2-clause or 3-clause BSD licensed, with the exception of bitvect, which is triple-licensed under the Artistic license, GPL, and LGPL	4 License: 2-clause or 3-clause BSD licensed, with the exception of bitvect, which is triple-licensed under the Artistic license, GPL, and LGPL

5 License File: source/patched-yasm/COPYING	5 License File: source/patched-yasm/COPYING

6 License Android Compatible: yes	6 License Android Compatible: yes

7 Security Critical: no	7 Security Critical: no

8	8

9 With these patches merged:	9 With these patches merged:

10 * https://github.com/yasm/yasm/commit/a2cbb10ee1b90b73647667ac849c74d65761d412	10 * https://github.com/yasm/yasm/commit/a2cbb10ee1b90b73647667ac849c74d65761d412

(...skipping 117 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
128	128

129 Yasm uses python scripts to generate the assembly code description	129 Yasm uses python scripts to generate the assembly code description

130 files in C++. Make sure to get these put into the gyp file properly as	130 files in C++. Make sure to get these put into the gyp file properly as

131 well. An example is gen_x86_insn.py for x86 assembly.	131 well. An example is gen_x86_insn.py for x86 assembly.

132	132

133 Note that at least the gen_x86_insn.py script suffers from the same	133 Note that at least the gen_x86_insn.py script suffers from the same

134 problem as genmacro in that it outputs to the current directory by	134 problem as genmacro in that it outputs to the current directory by

135 default. The yasm.gyp build patches this file before invoking it to	135 default. The yasm.gyp build patches this file before invoking it to

136 allow specifying an output directory.	136 allow specifying an output directory.

137	137

138 10) If all that's is finished, attempt to build....and cross your fingers.	138 10) Recreate the 'AdditionalOptions!': [ '/analyze' ] block so that VC++

	139 /analyze builds won't fail.

	140

	141 11) If all that's is finished, attempt to build....and cross your fingers.

OLD	NEW