Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 693933004: Revert of Turn on NVPR 4x MSAA by default when supported in DM and nanobench. (Closed)

Created:
6 years, 1 month ago by egdaniel
Modified:
6 years, 1 month ago
Reviewers:
bsalomon, mtklein, mtklein_C
CC:
reviews_skia.org, jcgregorio
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Turn on NVPR 4x MSAA by default when supported in DM and nanobench. (patchset #2 id:20001 of https://codereview.chromium.org/704563003/) Reason for revert: Timing out on nvpr when drawing conics. Fix will take some thought so reverting for now. Original issue's description: > Turn on NVPR 4x MSAA by default when supported in DM and nanobench. > > This brings DM and nanobench's default configs in line with GM's. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/31f88675718966bbb7f09718b40de10c7e214739 TBR=bsalomon@google.com,mtklein@google.com,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/d5cd4ee5b81b51e43be7ed13f3c0f0f6c1b3fe14

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -11 lines) Patch
M dm/DMGpuGMTask.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M dm/DMGpuSupport.h View 2 chunks +0 lines, -2 lines 0 comments Download
M include/gpu/gl/GrGLFunctions.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/flags/SkCommonFlags.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
egdaniel
Created Revert of Turn on NVPR 4x MSAA by default when supported in DM and ...
6 years, 1 month ago (2014-11-05 22:20:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693933004/1
6 years, 1 month ago (2014-11-05 22:21:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as d5cd4ee5b81b51e43be7ed13f3c0f0f6c1b3fe14
6 years, 1 month ago (2014-11-05 22:21:38 UTC) #3
mtklein
6 years, 1 month ago (2014-11-06 16:06:12 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/685923003/ by mtklein@google.com.

The reason for reverting is: Try again with loops overflow fix landed..

Powered by Google App Engine
This is Rietveld 408576698