snapshot/thread_snapshot.h - Issue 693933002: Add MinidumpThreadListWriter::InitializeFromSnapshot()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: snapshot/thread_snapshot.h

Issue 693933002: Add MinidumpThreadListWriter::InitializeFromSnapshot() (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@minidump_init_from_snapshot_context_new

Patch Set: Address review feedback Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: snapshot/thread_snapshot.h

diff --git a/snapshot/thread_snapshot.h b/snapshot/thread_snapshot.h

index 7ae883148f75f5db6bfd7c29aef1bcddf06dc38f..ba1c55cb6c0285fb08b621d65c6f951767501da6 100644

--- a/snapshot/thread_snapshot.h

+++ b/snapshot/thread_snapshot.h

@@ -36,7 +36,8 @@ class ThreadSnapshot {

virtual const CPUContext* Context() const = 0;

//! \brief Returns a MemorySnapshot object corresponding to the memory region

- //! that contains the thread’s stack.

+ //! that contains the thread’s stack, or `nullptr` if no stack region is

+ //! available.

//!

//! The caller does not take ownership of this object, it is scoped to the

//! lifetime of the ThreadSnapshot object that it was obtained from.

« no previous file with comments | « snapshot/test/test_thread_snapshot.cc ('k') | no next file » | no next file with comments »