Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 693933002: Add MinidumpThreadListWriter::InitializeFromSnapshot() (Closed)

Created:
6 years, 1 month ago by Mark Mentovai
Modified:
6 years, 1 month ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@minidump_init_from_snapshot_context_new
Project:
crashpad
Visibility:
Public.

Description

Add MinidumpThreadListWriter::InitializeFromSnapshot(), everything downstream, and tests. TEST=minidump_test R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/8248c030e25ea2b3d696b39b68cfb11e6b335673

Patch Set 1 #

Patch Set 2 : #

Total comments: 3

Patch Set 3 : Rebase #

Patch Set 4 : Address review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+744 lines, -1 line) Patch
M minidump/minidump.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
A minidump/minidump_thread_id_map.h View 1 chunk +52 lines, -0 lines 0 comments Download
A minidump/minidump_thread_id_map.cc View 1 chunk +66 lines, -0 lines 0 comments Download
A minidump/minidump_thread_id_map_test.cc View 1 2 3 1 chunk +190 lines, -0 lines 0 comments Download
M minidump/minidump_thread_writer.h View 4 chunks +28 lines, -0 lines 0 comments Download
M minidump/minidump_thread_writer.cc View 3 chunks +44 lines, -0 lines 0 comments Download
M minidump/minidump_thread_writer_test.cc View 3 chunks +191 lines, -0 lines 0 comments Download
M snapshot/cpu_context_test.cc View 1 2 chunks +16 lines, -0 lines 0 comments Download
M snapshot/snapshot.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A snapshot/test/test_thread_snapshot.h View 1 2 3 1 chunk +91 lines, -0 lines 0 comments Download
A snapshot/test/test_thread_snapshot.cc View 1 chunk +59 lines, -0 lines 0 comments Download
M snapshot/thread_snapshot.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Mark Mentovai
This depends on https://codereview.chromium.org/686353004/.
6 years, 1 month ago (2014-10-31 17:11:10 UTC) #2
Robert Sesek
https://codereview.chromium.org/693933002/diff/20001/minidump/minidump_thread_id_map_test.cc File minidump/minidump_thread_id_map_test.cc (right): https://codereview.chromium.org/693933002/diff/20001/minidump/minidump_thread_id_map_test.cc#newcode56 minidump/minidump_thread_id_map_test.cc:56: Everything above this line could go in SetUp() https://codereview.chromium.org/693933002/diff/20001/minidump/minidump_thread_id_map_test.cc#newcode57 ...
6 years, 1 month ago (2014-11-04 15:34:58 UTC) #3
Mark Mentovai
OK, updated. That made the test longer. It’s not worse, but I don’t know if ...
6 years, 1 month ago (2014-11-04 17:05:49 UTC) #4
Robert Sesek
On 2014/11/04 17:05:49, Mark Mentovai wrote: > OK, updated. > > That made the test ...
6 years, 1 month ago (2014-11-04 17:34:46 UTC) #5
Mark Mentovai
6 years, 1 month ago (2014-11-04 17:36:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
8248c030e25ea2b3d696b39b68cfb11e6b335673 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698