Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 69393003: Add minimum timeout for transient errors (Closed)

Created:
7 years, 1 month ago by Noam Samuel
Modified:
7 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add minimum timeout for transient errors Add minimum timeout for privet transient errors, so that when printers give a zero timeout, Chrome still waits between retries. NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235649

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/browser/local_discovery/privet_constants.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_impl.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_url_fetcher.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Noam Samuel
7 years, 1 month ago (2013-11-11 23:36:44 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm
7 years, 1 month ago (2013-11-11 23:41:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/69393003/1
7 years, 1 month ago (2013-11-11 23:54:56 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/browser/local_discovery/privet_http_impl.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 1 month ago (2013-11-11 23:54:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/69393003/1
7 years, 1 month ago (2013-11-14 18:26:26 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=190008
7 years, 1 month ago (2013-11-14 19:35:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/69393003/1
7 years, 1 month ago (2013-11-15 18:39:41 UTC) #7
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 1 month ago (2013-11-15 20:37:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/69393003/1
7 years, 1 month ago (2013-11-15 22:55:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/69393003/1
7 years, 1 month ago (2013-11-16 00:46:45 UTC) #10
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 07:57:27 UTC) #11
Message was sent while issue was closed.
Change committed as 235649

Powered by Google App Engine
This is Rietveld 408576698