Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 69393002: Enable Time::ThreadNow() on Android (Closed)

Created:
7 years, 1 month ago by fmeawad
Modified:
7 years, 1 month ago
Reviewers:
Mark Mentovai, ernstm
CC:
chromium-reviews, erikwright+watch_chromium.org, tonyg, klobag.chromium
Visibility:
Public.

Description

Enable Time::ThreadNow() on Android The current posix implementation supports getting the thread time but it was not enabled. This change enables it for Android. It was tested on N4, N7 2012 and 2013. BUG=317828 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234431

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M base/time/time.h View 1 chunk +1 line, -1 line 0 comments Download
M base/time/time_posix.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
fmeawad
I have also verified the base_unittest (TimeTicks.*). PTAL.
7 years, 1 month ago (2013-11-12 00:16:58 UTC) #1
ernstm
LGTM. We also need an OWNER's review for base. Adding mark@, who reviewed the original ...
7 years, 1 month ago (2013-11-12 01:03:52 UTC) #2
Mark Mentovai
LGTM
7 years, 1 month ago (2013-11-12 02:37:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmeawad@chromium.org/69393002/1
7 years, 1 month ago (2013-11-12 02:56:56 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-12 06:12:40 UTC) #5
Message was sent while issue was closed.
Change committed as 234431

Powered by Google App Engine
This is Rietveld 408576698