Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 693893005: Fix large cursors not to trigger MouseLock (Closed)

Created:
6 years, 1 month ago by Wez
Modified:
6 years, 1 month ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix large cursors not to trigger MouseLock BUG=429322 Committed: https://crrev.com/b54cf39856f9433ae450a70d162049b4c3fc6a9c Cr-Commit-Position: refs/heads/master@{#302493}

Patch Set 1 #

Patch Set 2 : Add an explicit HideMouseCursor() helper. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M remoting/client/plugin/chromoting_instance.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/plugin/pepper_input_handler.h View 1 1 chunk +6 lines, -2 lines 0 comments Download
M remoting/client/plugin/pepper_input_handler.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Wez
Quick-fix designed to be suitable for (low-risk) merge back to M39.
6 years, 1 month ago (2014-10-31 21:30:12 UTC) #2
Jamie
lgtm
6 years, 1 month ago (2014-10-31 21:57:12 UTC) #3
Wez
On 2014/10/31 21:57:12, Jamie wrote: > lgtm Qucik-fix of course provokes crbug.com/285809 so here's an ...
6 years, 1 month ago (2014-11-01 00:18:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693893005/20001
6 years, 1 month ago (2014-11-03 21:13:49 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-03 21:58:12 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 21:58:55 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b54cf39856f9433ae450a70d162049b4c3fc6a9c
Cr-Commit-Position: refs/heads/master@{#302493}

Powered by Google App Engine
This is Rietveld 408576698