Make cc::animation::TrimTimeToCurrentIteration,cc::AnimationCurve::Duration use TimeTicks/TimeDelta

cc/base/time_util.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CC_BASE_TIME_UTIL_H_
+#define CC_BASE_TIME_UTIL_H_
+
+namespace base {
+class TimeDelta;
+}
+
+namespace cc {
+

[ajuma, 2014/11/07 15:58:00]

Please define a TimeUtil class and make these functions be static members of
that class (see MathUtil as an example of this pattern).

[patro, 2014/11/10 09:46:52]

Done.

+static base::TimeDelta Scale(const base::TimeDelta time_delta, double value) {

[ajuma, 2014/11/07 15:58:00]

I assume you meant "const base::TimeDelta&"? A TimeDelta should be cheap to copy
(it consists of a single int64), so passing it by value should be fine. So this
should just be "base::TimeDelta".

[patro, 2014/11/10 09:46:52]

Done.

+  return base::TimeDelta::FromInternalValue(static_cast<int64>(
+      static_cast<double>(time_delta.ToInternalValue()) * value));
+}
+
+static base::TimeDelta Mod(const base::TimeDelta dividend,
+                           const base::TimeDelta divisor) {

[ajuma, 2014/11/07 15:58:00]

Same comment as above, please remove the consts here.

[patro, 2014/11/10 09:46:52]

Done.

+  return base::TimeDelta::FromInternalValue(dividend.ToInternalValue() %
+                                            divisor.ToInternalValue());
+}
+
+}  // namespace cc
+
+#endif  // CC_BASE_TIME_UTIL_H_