Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2536)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 693883003: Encode super calls via extra properties on prototypes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix handling of [Object] and stubs generation. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/reflection_data_parser.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
diff --git a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
index f67fe0030254043ea8bd3846ff4f2304649a6cf7..fce5372330fa5a595f9723b15dd429d612c0fe95 100644
--- a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
+++ b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart
@@ -1682,14 +1682,23 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
registry.registerDynamicGetter(selector);
registry.registerGetterForSuperMethod(node.element);
methodName = backend.namer.invocationName(selector);
- } else {
- methodName = backend.namer.getNameOfInstanceMember(superMethod);
- }
- push(
+ push(
js.js('#.prototype.#.call(#)', [
- backend.namer.elementAccess(superClass),
- methodName, visitArguments(node.inputs, start: 0)]),
+ backend.namer.elementAccess(superClass),
+ methodName, visitArguments(node.inputs, start: 0)]),
+ node);
+ } else {
+ methodName =
+ backend.namer.getNameOfAliasedSuperMember(superMethod);
+ backend.registerAliasedSuperMember(superMethod);
+ use(node.inputs.first);
+ push(
+ js.js('#.#(#)', [
+ pop(), methodName,
+ visitArguments(node.inputs, start: 1)]),
node);
+ }
+
}
}
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_emitter/old_emitter/reflection_data_parser.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698