Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 693883002: v8::Handle<T> is just an alias of v8::Local<T> so, replacing v8::Handle with v8::Local in src/compo… (Closed)

Created:
6 years, 1 month ago by anujsharma
Modified:
6 years, 1 month ago
Reviewers:
dcarney, blundell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

v8::Handle<T> is just an alias of v8::Local<T> so, replacing v8::Handle with v8::Local in src/components BUG=424445 Committed: https://crrev.com/0ee408a33ab88cf530651b7b29beaaa7adce0ef5 Cr-Commit-Position: refs/heads/master@{#302263}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/plugins/renderer/mobile_youtube_plugin.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
anujsharma
PTAL
6 years, 1 month ago (2014-10-31 13:50:02 UTC) #2
blundell
Please find a v8 owner to review this and then I'll rubberstamp. Thanks!
6 years, 1 month ago (2014-10-31 13:53:15 UTC) #3
anujsharma
On 2014/10/31 13:53:15, blundell wrote: > Please find a v8 owner to review this and ...
6 years, 1 month ago (2014-10-31 13:55:23 UTC) #5
dcarney
lgtm
6 years, 1 month ago (2014-10-31 13:58:54 UTC) #6
blundell
lgtm
6 years, 1 month ago (2014-10-31 13:59:38 UTC) #7
anujsharma
On 2014/10/31 13:58:54, dcarney wrote: > lgtm Thanks Dan for lgtm.
6 years, 1 month ago (2014-10-31 13:59:58 UTC) #8
anujsharma
On 2014/10/31 13:59:38, blundell wrote: > lgtm Thanks blundell for lgtm.
6 years, 1 month ago (2014-10-31 14:00:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693883002/1
6 years, 1 month ago (2014-10-31 14:00:48 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 14:35:15 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 14:35:57 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ee408a33ab88cf530651b7b29beaaa7adce0ef5
Cr-Commit-Position: refs/heads/master@{#302263}

Powered by Google App Engine
This is Rietveld 408576698