Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 693873002: Extend the git-cl-comments command functionality (Closed)

Created:
6 years, 1 month ago by apavlov
Modified:
6 years, 1 month ago
Reviewers:
dpranke, szager, iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Project:
tools
Visibility:
Public.

Description

Extend the git-cl-comments command functionality The "comments" command is taught to: - accept an arbitrary review issue id; - post comments on the current or specified review issue. This is required for the auto-rebaseline bot to notify a rebaseline requestor of the fact that the rebaseline has happened by means of posting a comment to the review issue that requested the rebaseline, as suggested by iannucci@. R=iannucci, szager, dpranke Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292844

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -21 lines) Patch
M git_cl.py View 2 chunks +37 lines, -21 lines 3 comments Download

Messages

Total messages: 10 (2 generated)
apavlov
6 years, 1 month ago (2014-10-31 13:06:56 UTC) #1
apavlov
PTAL
6 years, 1 month ago (2014-10-31 13:31:12 UTC) #3
iannucci
lgtm
6 years, 1 month ago (2014-10-31 23:27:31 UTC) #4
iannucci
oop, one comment. I think this breaks the default issue flow. https://codereview.chromium.org/693873002/diff/1/git_cl.py File git_cl.py (right): ...
6 years, 1 month ago (2014-10-31 23:29:12 UTC) #5
apavlov
https://codereview.chromium.org/693873002/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/693873002/diff/1/git_cl.py#newcode1446 git_cl.py:1446: help="review issue id (defaults to current issue)") On 2014/10/31 ...
6 years, 1 month ago (2014-11-01 06:59:21 UTC) #6
apavlov
https://codereview.chromium.org/693873002/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/693873002/diff/1/git_cl.py#newcode1456 git_cl.py:1456: cl = Changelist(issue=issue) If -i is not specified, the ...
6 years, 1 month ago (2014-11-01 20:06:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693873002/1
6 years, 1 month ago (2014-11-05 09:03:34 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 09:05:31 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 292844

Powered by Google App Engine
This is Rietveld 408576698