Add support for My Maps maps in Chrome OS Drive integration.

Add support for My Maps maps in Chrome OS Drive integration.

By this support, My Maps maps shown in Drive folder have correct icon, file-type description, and file extension.

BUG=397029
TEST=Manually create a form in drive.google.com and see it appears with an icon in Files.app.

Committed: https://crrev.com/227089035c26d235dcfb795e8444e8b0e04d15fb
Cr-Commit-Position: refs/heads/master@{#302593}

[fukino, 2014-10-31 12:56:57]

fukino@chromium.org changed reviewers:
+ hirono@chromium.org, kinaba@chromium.org, oshima@chromium.org

[fukino, 2014-10-31 12:56:58]

oshima@: PTAL at chrome/app/theme/*. I added an file-type icon for Google My
Maps maps
kinaba@: PTAL at chrome/browse/* and chromeos_strings.grdp
hirono@: PTAL at ui/*

[hirono, 2014-10-31 13:11:07]

https://codereview.chromium.org/693843002/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/file_type.js (right):

https://codereview.chromium.org/693843002/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/file_type.js:160: subtype: 'map',
pattern: /\.gmaps$/i
For other hosted docs, icon, subtype, and extension are consistent.
Can we choose one of map/maps ?

[fukino, 2014-10-31 13:18:55]

https://codereview.chromium.org/693843002/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/file_type.js (right):

https://codereview.chromium.org/693843002/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/file_type.js:160: subtype: 'map',
pattern: /\.gmaps$/i
On 2014/10/31 13:11:07, hirono wrote:
> For other hosted docs, icon, subtype, and extension are consistent.
> Can we choose one of map/maps ?

Because the .gmap extension is already known for another application, we choose
.gmaps extension.
But, in other parts, we use singular form to be consistent with other file
types.

[hirono, 2014-10-31 13:22:40]

On 2014/10/31 13:18:55, fukino wrote:
>
https://codereview.chromium.org/693843002/diff/20001/ui/file_manager/file_man...
> File ui/file_manager/file_manager/foreground/js/file_type.js (right):
> 
>
https://codereview.chromium.org/693843002/diff/20001/ui/file_manager/file_man...
> ui/file_manager/file_manager/foreground/js/file_type.js:160: subtype: 'map',
> pattern: /\.gmaps$/i
> On 2014/10/31 13:11:07, hirono wrote:
> > For other hosted docs, icon, subtype, and extension are consistent.
> > Can we choose one of map/maps ?
> 
> Because the .gmap extension is already known for another application, we
choose
> .gmaps extension.
> But, in other parts, we use singular form to be consistent with other file
> types.

SGTM and LGTM. Could you add comment about the extension to file_type.js?

[fukino, 2014-10-31 13:31:07]

On 2014/10/31 13:22:40, hirono wrote:
> On 2014/10/31 13:18:55, fukino wrote:
> >
>
https://codereview.chromium.org/693843002/diff/20001/ui/file_manager/file_man...
> > File ui/file_manager/file_manager/foreground/js/file_type.js (right):
> > 
> >
>
https://codereview.chromium.org/693843002/diff/20001/ui/file_manager/file_man...
> > ui/file_manager/file_manager/foreground/js/file_type.js:160: subtype: 'map',
> > pattern: /\.gmaps$/i
> > On 2014/10/31 13:11:07, hirono wrote:
> > > For other hosted docs, icon, subtype, and extension are consistent.
> > > Can we choose one of map/maps ?
> > 
> > Because the .gmap extension is already known for another application, we
> choose
> > .gmaps extension.
> > But, in other parts, we use singular form to be consistent with other file
> > types.
> 
> SGTM and LGTM. Could you add comment about the extension to file_type.js?

Done. Thanks!

[oshima, 2014-10-31 15:33:36]

c/a/t lgtm

[kinaba, 2014-11-04 03:19:22]

lgtm

[kinaba, 2014-11-04 03:23:44]

On 2014/11/04 03:19:22, kinaba wrote:
> lgtm

The current CL is lgtm, please go ahead, but I have one question.

Do we have any reason that we host all these file type icons (not only maps but
also others) under chrome://theme/?
If they are only accessed from Files.app, it is much much more natural to have
them inside chrome-extension://filesapp/.
My wild guess is that the current status is a left-over state from the very
initial version of the file manger that run in chrome://files URL.
@fukino, could you investigate and (if possible) clean them up?

[fukino, 2014-11-04 07:55:36]

On 2014/11/04 03:23:44, kinaba wrote:
> On 2014/11/04 03:19:22, kinaba wrote:
> > lgtm
> 
> The current CL is lgtm, please go ahead, but I have one question.
> 
> Do we have any reason that we host all these file type icons (not only maps
but
> also others) under chrome://theme/?
> If they are only accessed from Files.app, it is much much more natural to have
> them inside chrome-extension://filesapp/.
> My wild guess is that the current status is a left-over state from the very
> initial version of the file manger that run in chrome://files URL.
> @fukino, could you investigate and (if possible) clean them up?

It is me who moved file-type icons from filesapp to chrome://theme/...
(http://crrev.com/209433005)

Some file-type icons are shared with outside File.app(e.g. chrome://downloads)
via icon_loader_chromeos.cc.
Though only 5 file-type icons are shared, I put all file-type icons under
chrome://theme for consistency.
I'd like to keep them as they are for now.

[kinaba, 2014-11-04 08:12:31]

On 2014/11/04 07:55:36, fukino wrote:
> On 2014/11/04 03:23:44, kinaba wrote:
> > On 2014/11/04 03:19:22, kinaba wrote:
> > > lgtm
> > 
> > The current CL is lgtm, please go ahead, but I have one question.
> > 
> > Do we have any reason that we host all these file type icons (not only maps
> but
> > also others) under chrome://theme/?
> > If they are only accessed from Files.app, it is much much more natural to
have
> > them inside chrome-extension://filesapp/.
> > My wild guess is that the current status is a left-over state from the very
> > initial version of the file manger that run in chrome://files URL.
> > @fukino, could you investigate and (if possible) clean them up?
> 
> It is me who moved file-type icons from filesapp to chrome://theme/...
> (http://crrev.com/209433005)
> 
> Some file-type icons are shared with outside File.app(e.g. chrome://downloads)
> via icon_loader_chromeos.cc.
> Though only 5 file-type icons are shared, I put all file-type icons under
> chrome://theme for consistency.
> I'd like to keep them as they are for now.

sg. thanks

[fukino, 2014-11-04 08:13:26]

The CQ bit was checked by fukino@chromium.org

[commit-bot: I haz the power, 2014-11-04 08:14:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/693843002/40001

[commit-bot: I haz the power, 2014-11-04 09:00:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-11-04 09:01:16]

Patchset 3 (id:??) landed as
https://crrev.com/227089035c26d235dcfb795e8444e8b0e04d15fb
Cr-Commit-Position: refs/heads/master@{#302593}