Issue 69383003: don't use VS subdir for 2013 toolchain builder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 69383003: don't use VS subdir for 2013 toolchain builder (Closed)

Created:
7 years, 1 month ago by scottmg

Modified:
7 years, 1 month ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

don't use VS subdir for 2013 toolchain builder Was causing some problems with $(VCInstallDir) in gyp files, just put it in the root of the toolchain, the same as the 2010 script. R=cpu@chromium.org TBR=cpu@chromium.org BUG=309197 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234417

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -13 lines)			Patch
	M	tools/win/toolchain/toolchain2013.py	View		3 chunks	+13 lines, -13 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/69383003/1

7 years, 1 month ago (2013-11-11 23:19:03 UTC) #3

scottmg

7 years, 1 month ago (2013-11-12 05:28:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r234417 (presubmit successful).