Parser & internalizing: efficiency fixes.

src/ast-value-factory.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 223 matching lines @@
   if (content.IsOneByte()) {
     return GetOneByteString(content.ToOneByteVector());
   }
   DCHECK(content.IsTwoByte());
   return GetTwoByteString(content.ToUC16Vector());
 }
 
 
 const AstConsString* AstValueFactory::NewConsString(
     const AstString* left, const AstString* right) {
-  // This Vector will be valid as long as the Collector is alive (meaning that
-  // the AstRawString will not be moved).
   AstConsString* new_string = new (zone_) AstConsString(left, right);
-  strings_.Add(new_string);
   if (isolate_) {
     new_string->Internalize(isolate_);
+  } else {
+    strings_.Add(new_string);
   }
   return new_string;
 }
 
 
 void AstValueFactory::Internalize(Isolate* isolate) {
   if (isolate_) {
     // Everything is already internalized.
     return;
   }
   // Strings need to be internalized before values, because values refer to
   // strings.
   for (int i = 0; i < strings_.length(); ++i) {
     strings_[i]->Internalize(isolate);
   }
   for (int i = 0; i < values_.length(); ++i) {
     values_[i]->Internalize(isolate);
   }
   isolate_ = isolate;
 }
 
 
 const AstValue* AstValueFactory::NewString(const AstRawString* string) {
   AstValue* value = new (zone_) AstValue(string);
   DCHECK(string != NULL);
   if (isolate_) {
-    value->Internalize(isolate_);
+    // If we're creating immediately-internalized AstValues, the underlying
+    // strings must already be internalized at this point.
+    DCHECK(!string->string_.is_null());
   }
-  values_.Add(value);
+  // These AstValues don't need to be added to values_, since the AstRawStrings
+  // will be insternalized separately.
   return value;
 }
 
 
 const AstValue* AstValueFactory::NewSymbol(const char* name) {
   AstValue* value = new (zone_) AstValue(name);
   if (isolate_) {
     value->Internalize(isolate_);
+  } else {
+    values_.Add(value);
   }
-  values_.Add(value);
   return value;
 }
 
 
 const AstValue* AstValueFactory::NewNumber(double number) {
   AstValue* value = new (zone_) AstValue(number);
   if (isolate_) {
     value->Internalize(isolate_);
+  } else {
+    values_.Add(value);
   }
-  values_.Add(value);
   return value;
 }
 
 
 const AstValue* AstValueFactory::NewSmi(int number) {
   AstValue* value =
       new (zone_) AstValue(AstValue::SMI, number);
   if (isolate_) {
     value->Internalize(isolate_);
+  } else {
+    values_.Add(value);
   }
-  values_.Add(value);
   return value;
 }
 
 
 #define GENERATE_VALUE_GETTER(value, initializer) \
   if (!value) {                                   \
     value = new (zone_) AstValue(initializer);    \
     if (isolate_) {                               \
       value->Internalize(isolate_);               \
+    } else {                                      \
+      values_.Add(value);                         \
     }                                             \
-    values_.Add(value);                           \
   }                                               \
   return value;
 
 
 const AstValue* AstValueFactory::NewBoolean(bool b) {
   if (b) {
     GENERATE_VALUE_GETTER(true_value_, true);
   } else {
     GENERATE_VALUE_GETTER(false_value_, false);
   }
@@ skipping 26 matching lines @@
   AstRawString key(is_one_byte, literal_bytes, hash);
   HashMap::Entry* entry = string_table_.Lookup(&key, hash, true);
   if (entry->value == NULL) {
     // Copy literal contents for later comparison.
     int length = literal_bytes.length();
     byte* new_literal_bytes = zone_->NewArray<byte>(length);
     memcpy(new_literal_bytes, literal_bytes.start(), length);
     AstRawString* new_string = new (zone_) AstRawString(
         is_one_byte, Vector<const byte>(new_literal_bytes, length), hash);
     entry->key = new_string;
-    strings_.Add(new_string);
     if (isolate_) {
       new_string->Internalize(isolate_);
+    } else {
+      strings_.Add(new_string);
     }
     entry->value = reinterpret_cast<void*>(1);
   }
   return reinterpret_cast<AstRawString*>(entry->key);
 }
 
 
 } }  // namespace v8::internal