Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 693803004: Parser & internalizing: efficiency fixes. (Closed)

Created:
6 years, 1 month ago by marja
Modified:
5 years, 8 months ago
Reviewers:
rossberg
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Parser & internalizing: efficiency fixes. 1) In ParseLazy, we're already using the heap, so we can also tell AstValueFactory to internalize immediately. This is more efficient. 2) No need to collect the values in values_ and strings_ if they're already internalized. 3) No need to collect AstValues which are strings in values_ since they don't need to be internalized (the underlying strings will be internalized separately). BUG=429168 LOG=N R=rossberg@chromium.org

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -10 lines) Patch
M src/ast-value-factory.cc View 1 2 7 chunks +17 lines, -10 lines 0 comments Download
M src/parser.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
marja
rossberg@, ptal. We lost around 7% in MandreelLatency w/ --predictable when I landed the original ...
6 years, 1 month ago (2014-11-04 13:48:04 UTC) #2
rossberg
lgtm
6 years, 1 month ago (2014-11-04 13:56:44 UTC) #3
marja
6 years, 1 month ago (2014-11-04 14:16:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 25109 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698