Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Unified Diff: sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes_sexpr.dart

Issue 693803003: Move continueWithExpression to IrBuilder. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes_sexpr.dart
diff --git a/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes_sexpr.dart b/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes_sexpr.dart
index 5169ee7d73abbd3bab86fcd471603c4b19c8b736..c4621cb605b85f18245a5e028eacd95ae3172c4e 100644
--- a/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes_sexpr.dart
+++ b/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes_sexpr.dart
@@ -28,8 +28,8 @@ class SExpressionStringifier extends Visitor<String> with Indentation {
})
.join(' ');
String body = indentBlock(() => visit(node.body));
- return '$indentation(FunctionDefinition $name ($parameters return)\n' +
- '$body)';
+ return '$indentation(FunctionDefinition $name ($parameters return)\n'
+ '$body)';
}
String visitLetPrim(LetPrim node) {
@@ -53,8 +53,8 @@ class SExpressionStringifier extends Visitor<String> with Indentation {
String contBody = indentBlock(() => visit(node.continuation.body));
String body = visit(node.body);
String op = node.continuation.isRecursive ? 'LetCont*' : 'LetCont';
- return '$indentation($op ($cont$parameters)\n' +
- '$contBody)\n' +
+ return '$indentation($op ($cont$parameters)\n'
+ '$contBody)\n'
'$body';
}
@@ -160,15 +160,15 @@ class SExpressionStringifier extends Visitor<String> with Indentation {
String visitSetClosureVariable(SetClosureVariable node) {
String value = names[node.value.definition];
String body = indentBlock(() => visit(node.body));
- return '$indentation(SetClosureVariable ${node.variable.name} $value\n' +
- '$body)';
+ return '$indentation(SetClosureVariable ${node.variable.name} $value\n'
+ '$body)';
}
String visitTypeOperator(TypeOperator node) {
String receiver = names[node.receiver.definition];
String cont = names[node.continuation.definition];
- return '$indentation(TypeOperator ${node.operator} $receiver ' +
- '${node.type} $cont)';
+ String operator = node.isTypeTest ? 'is' : 'as';
+ return '$indentation(TypeOperator $operator $receiver ${node.type} $cont)';
}
String visitLiteralList(LiteralList node) {
@@ -186,9 +186,9 @@ class SExpressionStringifier extends Visitor<String> with Indentation {
String visitDeclareFunction(DeclareFunction node) {
String function = indentBlock(() => visit(node.definition));
String body = indentBlock(() => visit(node.body));
- return '$indentation(DeclareFunction ${node.variable.name} =\n' +
- '$function in\n' +
- '$body)';
+ return '$indentation(DeclareFunction ${node.variable.name} =\n'
+ '$function in\n'
+ '$body)';
}
String visitIsTrue(IsTrue node) {

Powered by Google App Engine
This is Rietveld 408576698