Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 693803002: Add a UseCounter for CustomScrollbar (Closed)

Created:
6 years, 1 month ago by MuVen
Modified:
6 years, 1 month ago
Reviewers:
esprehn, enne (OOO)
CC:
blink-reviews, sivag, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add a UseCounter for CustomScrollbar This CL adds histogram statistics for the following CustomScrollbar-related CSS selectors. - CSSSelectorPseudoScrollbar - CSSSelectorPseudoScrollbarButton - CSSSelectorPseudoScrollbarThumb - CSSSelectorPseudoScrollbarTrack - CSSSelectorPseudoScrollbarTrackPiece Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184820

Patch Set 1 : #

Total comments: 1

Patch Set 2 : addressed review comments #

Patch Set 3 : rebased to latest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M Source/core/frame/UseCounter.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderScrollbarPart.cpp View 1 2 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
MuVen
PTAL.
6 years, 1 month ago (2014-10-31 12:09:59 UTC) #4
esprehn
This seems fine, but note that most Google properties use custom scrollbar so the number ...
6 years, 1 month ago (2014-10-31 17:21:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693803002/60001
6 years, 1 month ago (2014-11-04 05:21:51 UTC) #7
commit-bot: I haz the power
Failed to apply patch for Source/core/frame/UseCounter.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 1 month ago (2014-11-04 05:21:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693803002/80001
6 years, 1 month ago (2014-11-04 05:34:53 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 06:39:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as 184820

Powered by Google App Engine
This is Rietveld 408576698