Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Issue 6937003: modified nacl_sync.h to have NACL_WUR for all functions that return a (Closed)

Created:
9 years, 7 months ago by bsy
Modified:
9 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

modified nacl_sync.h to have NACL_WUR for all functions that return a value. added checked versions of ctors for mutexes and condvars. found and fixed a cut-n-paste error in NaClXCondVarTimedWaitRelative. and... fixed all compiler warnings to use the checked versions of the synchronization functions. this is primarily a code cleanup but may aid in information gathering for http://code.google.com/p/nativeclient/issues/detail?id=1763 BUG= None TEST= None Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=5183

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -230 lines) Patch
A src/include/nacl_compiler_annotations.h View 1 chunk +59 lines, -0 lines 0 comments Download
M src/include/portability.h View 1 2 3 3 chunks +5 lines, -77 lines 0 comments Download
M src/shared/imc/sigpipe_test.cc View 1 2 3 8 chunks +33 lines, -32 lines 0 comments Download
M src/shared/platform/nacl.scons View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/shared/platform/nacl_global_secure_random.c View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M src/shared/platform/nacl_interruptible_condvar.c View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M src/shared/platform/nacl_interruptible_mutex.c View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M src/shared/platform/nacl_log.c View 1 2 3 4 chunks +4 lines, -3 lines 0 comments Download
M src/shared/platform/nacl_semaphore_test.c View 1 2 3 4 chunks +13 lines, -12 lines 0 comments Download
M src/shared/platform/nacl_sync.h View 1 2 3 3 chunks +14 lines, -13 lines 0 comments Download
M src/shared/platform/nacl_sync_checked.h View 1 2 3 2 chunks +5 lines, -3 lines 0 comments Download
M src/shared/platform/nacl_sync_checked.c View 1 2 3 5 chunks +18 lines, -6 lines 0 comments Download
M src/trusted/desc/nacl_desc_wrapper.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/trusted/service_runtime/fs/obj_proxy.c View 1 2 3 6 chunks +9 lines, -9 lines 0 comments Download
M src/trusted/service_runtime/linux/x86/nacl_ldt.c View 1 2 3 5 chunks +9 lines, -8 lines 0 comments Download
M src/trusted/service_runtime/nacl_globals.c View 1 2 3 3 chunks +6 lines, -4 lines 0 comments Download
M src/trusted/service_runtime/nacl_sync_cond_test.c View 1 2 3 6 chunks +9 lines, -9 lines 0 comments Download
M src/trusted/service_runtime/nacl_sync_queue.c View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M src/trusted/service_runtime/nacl_syscall_common.c View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M src/trusted/service_runtime/nacl_text.c View 1 2 3 9 chunks +19 lines, -17 lines 0 comments Download
M src/trusted/service_runtime/osx/nacl_ldt.c View 1 2 3 6 chunks +9 lines, -8 lines 0 comments Download
M src/trusted/service_runtime/sel_ldr.c View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/trusted/service_runtime/sel_ldr_standard.c View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bsy
PTaL
9 years, 7 months ago (2011-05-05 02:20:47 UTC) #1
sehr (please use chromium)
On 2011/05/05 02:20:47, bsy wrote: > PTaL LGTM.
9 years, 7 months ago (2011-05-05 03:22:55 UTC) #2
bsy
9 years, 7 months ago (2011-05-05 19:24:34 UTC) #3
thx.  r5183

On Wed, May 4, 2011 at 8:22 PM, <sehr@google.com> wrote:

> On 2011/05/05 02:20:47, bsy wrote:
>
>> PTaL
>>
>
> LGTM.
>
>
> http://codereview.chromium.org/6937003/
>



-- 
bennet s yee
i usually don't capitalize due to mild tendonitis

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

Powered by Google App Engine
This is Rietveld 408576698