Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 693623003: Fix system freeze in accessibility focus ring code. (Closed)

Created:
6 years, 1 month ago by dmazzoni
Modified:
6 years, 1 month ago
Reviewers:
xiyuan
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@682583002
Project:
chromium
Visibility:
Public.

Description

Fix system freeze in accessibility focus ring code. The change to accessibility_focus_ring_layer.cc prevents an endless loop if the input ring is all the same point. The change to accessibility_focus_ring_controller.cc addresses the underlying cause - the timestamp we get from CompositorAnimationObserver::OnAnimationStep is not guaranteed to be later than the most recent focus time (in practice, it's up to 0.002 s earlier on an ARM Chromebook). A negative delta time turned into NaN when we computed pow(fraction, 0.3) and that led to the input ring being all zeros, triggering the issue above. BUG=427649 Committed: https://crrev.com/822d339a7a1c626781180fd233781de7d760eef1 Cr-Commit-Position: refs/heads/master@{#302178}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/chromeos/ui/accessibility_focus_ring_controller.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/ui/accessibility_focus_ring_layer.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dmazzoni
6 years, 1 month ago (2014-10-30 21:49:00 UTC) #2
xiyuan
lgtm
6 years, 1 month ago (2014-10-30 21:59:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693623003/1
6 years, 1 month ago (2014-10-30 22:00:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 22:43:37 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 22:44:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/822d339a7a1c626781180fd233781de7d760eef1
Cr-Commit-Position: refs/heads/master@{#302178}

Powered by Google App Engine
This is Rietveld 408576698