Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: LayoutTests/animations/resources/animation-test-helpers.js

Issue 693613006: Remove "static:" element type from animation-test-helpers.js (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/animations/cross-fade-webkit-mask-image.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/animations/resources/animation-test-helpers.js
diff --git a/LayoutTests/animations/resources/animation-test-helpers.js b/LayoutTests/animations/resources/animation-test-helpers.js
index 28385d1a8dff22b61c1697417e38274a7f5a95d2..78fbd841bb00530232c0d3d6a956c4969e593d84 100644
--- a/LayoutTests/animations/resources/animation-test-helpers.js
+++ b/LayoutTests/animations/resources/animation-test-helpers.js
@@ -20,8 +20,7 @@ Function parameters:
[1] If a single string is passed, it is the id of the element to test. If an array with 2 elements is passed they
are the ids of 2 elements, whose values are compared for equality. In this case the expected value is ignored
- but the tolerance is used in the comparison. If the second element is prefixed with "static:", no animation on that
- element is required, allowing comparison with an unanimated "expected value" element.
+ but the tolerance is used in the comparison.
If a string with a '.' is passed, this is an element in an iframe. The string before the dot is the iframe id
and the string after the dot is the element name in that iframe.
@@ -152,20 +151,14 @@ function checkExpectedValue(expected, index)
// Check for a pair of element Ids
var compareElements = false;
- var element2Static = false;
var elementId2;
if (typeof elementId != "string") {
if (elementId.length != 2)
return;
-
+
elementId2 = elementId[1];
elementId = elementId[0];
- if (elementId2.indexOf("static:") == 0) {
- elementId2 = elementId2.replace("static:", "");
- element2Static = true;
- }
-
compareElements = true;
}
« no previous file with comments | « LayoutTests/animations/cross-fade-webkit-mask-image.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698