Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 693613006: Remove "static:" element type from animation-test-helpers.js (Closed)

Created:
6 years, 1 month ago by Timothy Loh
Modified:
6 years, 1 month ago
CC:
blink-reviews, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove "static:" element type from animation-test-helpers.js Currently animation-test-helpers.js supports prefixing element ids with "static:". This patch removes this prefix as we just just remove them and do nothing differently. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185147

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -17 lines) Patch
M LayoutTests/animations/cross-fade-background-image.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/animations/cross-fade-border-image-source.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/animations/cross-fade-list-style-image.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/animations/cross-fade-webkit-mask-box-image.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/animations/cross-fade-webkit-mask-image.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/animations/resources/animation-test-helpers.js View 2 chunks +2 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Timothy Loh
6 years, 1 month ago (2014-11-11 18:24:01 UTC) #2
alancutter (OOO until 2018)
lgtm
6 years, 1 month ago (2014-11-11 18:32:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693613006/1
6 years, 1 month ago (2014-11-11 18:33:41 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 21:40:11 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 185147

Powered by Google App Engine
This is Rietveld 408576698