Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 693613003: Revert "Revert of Add Search Service in Enhanced Bookmark Bridge (patchset #6 id:100001 of https://… (Closed)

Created:
6 years, 1 month ago by danduong
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Revert of Add Search Service in Enhanced Bookmark Bridge (patchset #6 id:100001 of https://codereview.chromium.org/637323005/)" This reverts commit 1491f336d849dcf168cc8832e91a7c8213dd2a7f. BUG=415774 TBR=yfriedman Committed: https://crrev.com/b8cf2351275e5732082956fc947d71c2b6ca8de0 Cr-Commit-Position: refs/heads/master@{#302165}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -44 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/EnhancedBookmarksBridge.java View 7 chunks +69 lines, -7 lines 0 comments Download
M chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.h View 3 chunks +11 lines, -3 lines 0 comments Download
M chrome/browser/android/enhanced_bookmarks/enhanced_bookmarks_bridge.cc View 6 chunks +45 lines, -3 lines 0 comments Download
M components/enhanced_bookmarks/bookmark_server_search_service.h View 3 chunks +18 lines, -8 lines 0 comments Download
M components/enhanced_bookmarks/bookmark_server_search_service.cc View 4 chunks +31 lines, -23 lines 0 comments Download
M components/enhanced_bookmarks/bookmark_server_service.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/enhanced_bookmarks/bookmark_server_service.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
danduong
Last time I landed this, I had a collision with Ian. One of us needs ...
6 years, 1 month ago (2014-10-30 20:13:31 UTC) #3
Kibeom Kim (inactive)
lgtm
6 years, 1 month ago (2014-10-30 20:31:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693613003/1
6 years, 1 month ago (2014-10-30 21:09:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/21348)
6 years, 1 month ago (2014-10-30 21:16:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693613003/1
6 years, 1 month ago (2014-10-30 21:24:55 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 21:53:41 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 21:54:26 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b8cf2351275e5732082956fc947d71c2b6ca8de0
Cr-Commit-Position: refs/heads/master@{#302165}

Powered by Google App Engine
This is Rietveld 408576698