[DevTools] Split DevToolsHttpHandler into two classes

content/browser/devtools/devtools_http_handler_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_HTTP_HANDLER_IMPL_H_
 #define CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_HTTP_HANDLER_IMPL_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 16 matching lines @@
 class Value;
 }
 
 namespace net {
 class ServerSocketFactory;
 class URLRequestContextGetter;
 }
 
 namespace content {
 
-class DevToolsHttpHandlerImpl
-    : public DevToolsHttpHandler,
-      public base::RefCountedThreadSafe<DevToolsHttpHandlerImpl>,
-      public net::HttpServer::Delegate {
+class DevToolsHttpHandlerImpl : public DevToolsHttpHandler {
  private:
-  friend class base::RefCountedThreadSafe<DevToolsHttpHandlerImpl>;
   friend class DevToolsHttpHandler;
 
   class BrowserTarget;
+  class ServerWrapper;
+  class AgentHostClientImpl;
 
   DevToolsHttpHandlerImpl(scoped_ptr<ServerSocketFactory> server_socket_factory,
                           const std::string& frontend_url,
                           DevToolsHttpHandlerDelegate* delegate,
-                          const base::FilePath& active_port_output_directory);
+                          const base::FilePath& output_directory);
   ~DevToolsHttpHandlerImpl() override;
-  void Start();
 
   // DevToolsHttpHandler implementation.
   void Stop() override;
   GURL GetFrontendURL() override;
 
-  // net::HttpServer::Delegate implementation.
-  void OnConnect(int connection_id) override {}
-  void OnHttpRequest(int connection_id,
-                     const net::HttpServerRequestInfo& info) override;
+  void OnJsonRequest(int connection_id,

[dgozman, 2014/11/07 13:03:55]

Can we extract meaningful methods to a separate "dispatcher" class, and let the
handler just manage lifetime of thread, server wrapper and dispatcher?

[vkuzkokov, 2014/11/10 09:04:34]

Extracted to static methods.

+                     const net::HttpServerRequestInfo& info);
+  void OnThumbnailRequest(int connection_id, const std::string& target_id);
+  void OnDiscoveryPageRequest(int connection_id);
+
   void OnWebSocketRequest(int connection_id,
-                          const net::HttpServerRequestInfo& info) override;
-  void OnWebSocketMessage(int connection_id, const std::string& data) override;
-  void OnClose(int connection_id) override;
+                          const net::HttpServerRequestInfo& info);
+  void OnWebSocketMessage(int connection_id, const std::string& data);
+  void OnClose(int connection_id);
 
-  void OnJsonRequestUI(int connection_id,
-                       const net::HttpServerRequestInfo& info);
-  void OnThumbnailRequestUI(int connection_id, const GURL& page_url);
-  void OnDiscoveryPageRequestUI(int connection_id);
-
-  void OnWebSocketRequestUI(int connection_id,
-                            const net::HttpServerRequestInfo& info);
-  void OnWebSocketMessageUI(int connection_id, const std::string& data);
-  void OnCloseUI(int connection_id);
-
-  void ResetHandlerThread();
-  void ResetHandlerThreadAndRelease();
+  static void OnTargetListReceivedWeak(

[dgozman, 2014/11/07 13:03:56]

Let's comment on the purpose of this method.

[vkuzkokov, 2014/11/10 09:04:34]

File removed.

+      base::WeakPtr<DevToolsHttpHandlerImpl> handler,
+      int connection_id,
+      const std::string& host,
+      const DevToolsManagerDelegate::TargetList& targets);
 
   void OnTargetListReceived(
       int connection_id,
       const std::string& host,
       const DevToolsManagerDelegate::TargetList& targets);
 
-  void OnHttpServerInitialized(const net::IPEndPoint& ip_address);
-
   DevToolsTarget* GetTarget(const std::string& id);
 
-  void Init();
-  void Teardown();
+  void ThreadStarted(scoped_ptr<ServerSocketFactory> server_socket_factory,
+                     const base::FilePath& output_directory,
+                     scoped_ptr<base::Thread> thread);
+  void ServerStarted(scoped_ptr<ServerWrapper> server,
+                     scoped_ptr<net::IPEndPoint> ip_address);
 
-  void StartHandlerThread();
   void StopHandlerThread();
-  void StopWithoutRelease();
-
-  void WriteActivePortToUserProfile();
 
   void SendJson(int connection_id,
                 net::HttpStatusCode status_code,
                 base::Value* value,
                 const std::string& message);
   void Send200(int connection_id,
                const std::string& data,
                const std::string& mime_type);
   void Send404(int connection_id);
   void Send500(int connection_id,
                const std::string& message);
   void AcceptWebSocket(int connection_id,
                        const net::HttpServerRequestInfo& request);
 
   // Returns the front end url without the host at the beginning.
   std::string GetFrontendURLInternal(const std::string target_id,
                                      const std::string& host);
 
   base::DictionaryValue* SerializeTarget(const DevToolsTarget& target,
                                          const std::string& host);
 
   // The thread used by the devtools handler to run server socket.
   scoped_ptr<base::Thread> thread_;
 
   std::string frontend_url_;
-  const scoped_ptr<ServerSocketFactory> server_socket_factory_;
-  scoped_ptr<net::HttpServer> server_;
+  scoped_ptr<ServerWrapper> server_;

[dgozman, 2014/11/07 13:03:55]

Let's call this |server_wrapper_|.

[vkuzkokov, 2014/11/10 09:04:34]

Done.

   scoped_ptr<net::IPEndPoint> server_ip_address_;
-  typedef std::map<int, DevToolsAgentHostClient*> ConnectionToClientMap;
-  ConnectionToClientMap connection_to_client_ui_;
+  typedef std::map<int, AgentHostClientImpl*> ConnectionToClientMap;
+  ConnectionToClientMap connection_to_client_;
   const scoped_ptr<DevToolsHttpHandlerDelegate> delegate_;
-  const base::FilePath active_port_output_directory_;
   typedef std::map<std::string, DevToolsTarget*> TargetMap;
   TargetMap target_map_;
   typedef std::map<int, BrowserTarget*> BrowserTargets;
   BrowserTargets browser_targets_;
+  base::WeakPtrFactory<DevToolsHttpHandlerImpl> weak_factory_;
+
   DISALLOW_COPY_AND_ASSIGN(DevToolsHttpHandlerImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_DEVTOOLS_DEVTOOLS_HTTP_HANDLER_IMPL_H_