chrome/browser/chromeos/login/ui/login_display_host_impl.cc - Issue 693523003: MacViews: Put wm window animation calls behind an interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/ui/login_display_host_impl.cc

Issue 693523003: MacViews: Put wm window animation calls behind an interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@views-clipboard

Patch Set: Fix windows build Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/ui/lock_window_aura.cc ('k') | chrome/browser/ui/views/autofill/autofill_popup_base_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/ui/login_display_host_impl.cc

diff --git a/chrome/browser/chromeos/login/ui/login_display_host_impl.cc b/chrome/browser/chromeos/login/ui/login_display_host_impl.cc

index 61546683428dd3d0ff6952a5b6a2c7d766860067..8afcca685ce29527fbbc5645d6a7f66dbcb163c3 100644

--- a/chrome/browser/chromeos/login/ui/login_display_host_impl.cc

+++ b/chrome/browser/chromeos/login/ui/login_display_host_impl.cc

@@ -87,7 +87,6 @@

#include "ui/views/focus/focus_manager.h"

#include "ui/views/widget/widget.h"

#include "ui/views/widget/widget_delegate.h"

-#include "ui/wm/core/window_animations.h"

#include "url/gurl.h"

#if !defined(USE_ATHENA)

@@ -1104,12 +1103,9 @@ void LoginDisplayHostImpl::InitLoginWindowAndView() {

if (login_view_->webui_visible())

OnLoginPromptVisible();

- wm::SetWindowVisibilityAnimationDuration(

- login_window_->GetNativeView(),

+ login_window_->SetVisibilityAnimationDuration(

base::TimeDelta::FromMilliseconds(kLoginFadeoutTransitionDurationMs));

- wm::SetWindowVisibilityAnimationTransition(

- login_window_->GetNativeView(),

- wm::ANIMATE_HIDE);

+ login_window_->SetVisibilityAnimationTransition(views::Widget::ANIMATE_HIDE);

login_window_->AddRemovalsObserver(this);

login_window_->SetContentsView(login_view_);