Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 693503002: Files.app: Make NamingControll class. (Closed)

Created:
6 years, 1 month ago by hirono
Modified:
6 years, 1 month ago
Reviewers:
fukino
CC:
chromium-reviews, vitalyp+closure_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Files.app: Make NamingControll class. BUG=267281 TEST=None Committed: https://crrev.com/aa7dae2ed699528d28ae6d06b9195fb6926f6efd Cr-Commit-Position: refs/heads/master@{#302220}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -29 lines) Patch
M ui/file_manager/file_manager/foreground/js/compiled_resources.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 2 7 chunks +21 lines, -29 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/main_scripts.js View 1 chunk +1 line, -0 lines 0 comments Download
A ui/file_manager/file_manager/foreground/js/naming_controller.js View 1 chunk +52 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/main.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hirono
PTAL the CL? Thank you!
6 years, 1 month ago (2014-10-30 12:20:38 UTC) #2
fukino
On 2014/10/30 12:20:38, hirono wrote: > PTAL the CL? Thank you! lgtm!
6 years, 1 month ago (2014-10-31 03:58:05 UTC) #3
hirono
On 2014/10/31 03:58:05, fukino wrote: > On 2014/10/30 12:20:38, hirono wrote: > > PTAL the ...
6 years, 1 month ago (2014-10-31 04:01:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693503002/40001
6 years, 1 month ago (2014-10-31 04:02:32 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-10-31 04:45:08 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 04:45:48 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/aa7dae2ed699528d28ae6d06b9195fb6926f6efd
Cr-Commit-Position: refs/heads/master@{#302220}

Powered by Google App Engine
This is Rietveld 408576698