Use base::GetBuildTime in MetricsLog::GetBuildTime instead of reimplementing it.

components/metrics/metrics_log.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/metrics/metrics_log.h"
 
 #include <algorithm>
 #include <string>
 #include <vector>
 
 #include "base/base64.h"
 #include "base/basictypes.h"
+#include "base/build_time.h"
 #include "base/cpu.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/metrics/histogram.h"
 #include "base/metrics/histogram_samples.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
 #include "base/sha1.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 126 matching lines @@
   // being hashed to a given MD5 value by just running the version of Chromium
   // in question with --enable-logging.
   DVLOG(1) << "Metrics: Hash numeric [" << value << "]=[" << hash << "]";
 
   return hash;
 }
 
 // static
 int64 MetricsLog::GetBuildTime() {
   static int64 integral_build_time = 0;
-  if (!integral_build_time) {
-    base::Time time;
-    static const char kDateTime[] = __DATE__ " " __TIME__ " GMT";

[M-A Ruel, 2014/10/31 14:09:14]

Note that the PST / GMT difference was pure hack; base/build_time.cc totally
assumes PST, this totally assumes GMT, both are *wrong* but this one was more
wrong.

The right fix is:
- Remove this implementation (e.g. this CL is right).
- Fix base/build_time.cc to stop assuming PST (which is wrong, it's PDT most of
the time, it assumes timezone settings on the official builder) and use a
resource instead of __TIME__. Other solutions includes toolset specific things
like
http://stackoverflow.com/questions/5844701/how-do-i-get-the-utc-offset-for-time.
This is out of scope for this CL.

I recommend:
- filing a bug for the timezone issue with base::GetBuildTime()
- closing https://code.google.com/p/chromium/issues/detail?id=326158 as Fixed,
as this CL uses ToTimeT() which converts to UTC.
- Take the hit with metrics 1-day data inconsistency while people are upgraded
due to the bug here.

-    bool result = base::Time::FromString(kDateTime, &time);
-    DCHECK(result);
-    integral_build_time = static_cast<int64>(time.ToTimeT());
-  }
+  if (!integral_build_time)
+    integral_build_time = static_cast<int64>(base::GetBuildTime().ToTimeT());
   return integral_build_time;
 }
 
 // static
 int64 MetricsLog::GetCurrentTime() {
   return (base::TimeTicks::Now() - base::TimeTicks()).InSeconds();
 }
 
 void MetricsLog::RecordUserAction(const std::string& key) {
   DCHECK(!closed_);
@@ skipping 254 matching lines @@
   DCHECK(!closed_);
   closed_ = true;
 }
 
 void MetricsLog::GetEncodedLog(std::string* encoded_log) {
   DCHECK(closed_);
   uma_proto_.SerializeToString(encoded_log);
 }
 
 }  // namespace metrics