Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 693493004: Revert of Allow POSIX callers to specify a new file's mode. (Closed)

Created:
6 years, 1 month ago by csharp1
Modified:
6 years, 1 month ago
Reviewers:
palmer
CC:
chromium-reviews, benjhayden+dwatch_chromium.org, darin-cc_chromium.org, asanka, erikwright+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Allow POSIX callers to specify a new file's mode. (patchset #1 id:1 of https://codereview.chromium.org/689713006/) Reason for revert: This seems to have broken the Linux MSan test bot. [ RUN ] FileUtilTest.WriteFileWithMode ../../base/files/file_util_unittest.cc:2164: Failure Value of: status.st_mode & 0777 Actual: 384 Expected: mode Which is: 420 [ FAILED ] FileUtilTest.WriteFileWithMode (1 ms) Original issue's description: > Allow POSIX callers to specify a new file's mode. > > Retain the tight 0640 mode for most existing callers, but honor the user's > umask for downloaded files. > > This is a re-land of https://codereview.chromium.org/639253004/. > > BUG=409416, 362887 > TBR=asanka,mdempsky,rvargas > > Committed: https://crrev.com/931e35070097af9837f79ff19f8668e45b92ed3a > Cr-Commit-Position: refs/heads/master@{#302113} TBR=palmer@chromium.org NOTREECHECKS=true NOTRY=true BUG=409416, 362887 Committed: https://crrev.com/8db8e88e009aba7fd5448383df2a4645802d19af Cr-Commit-Position: refs/heads/master@{#302143}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -66 lines) Patch
M base/files/file_util.h View 2 chunks +0 lines, -8 lines 0 comments Download
M base/files/file_util_posix.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M base/files/file_util_unittest.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M content/browser/download/base_file_posix.cc View 1 chunk +20 lines, -27 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
csharp1
Created Revert of Allow POSIX callers to specify a new file's mode.
6 years, 1 month ago (2014-10-30 20:10:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693493004/1
6 years, 1 month ago (2014-10-30 20:12:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 20:13:52 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 20:14:52 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8db8e88e009aba7fd5448383df2a4645802d19af
Cr-Commit-Position: refs/heads/master@{#302143}

Powered by Google App Engine
This is Rietveld 408576698