Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1108)

Issue 693483004: Enable Oilpan for core/timing/. (Closed)

Created:
6 years, 1 month ago by sof
Modified:
5 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, kouhei+heap_chromium.org, arv+blink, Inactive, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Enable Oilpan for core/timing/. R=haraken BUG=479467 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194227

Patch Set 1 #

Patch Set 2 : rebased and refreshed #

Total comments: 8

Patch Set 3 : de-weakify Performance::m_memoryInfo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -66 lines) Patch
M Source/core/timing/ConsoleMemory.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/timing/DOMWindowPerformance.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/timing/DOMWindowPerformance.cpp View 1 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/timing/MemoryInfo.h View 1 1 chunk +3 lines, -5 lines 0 comments Download
M Source/core/timing/MemoryInfo.idl View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/timing/Performance.h View 1 2 4 chunks +9 lines, -9 lines 0 comments Download
M Source/core/timing/Performance.cpp View 1 5 chunks +13 lines, -6 lines 0 comments Download
M Source/core/timing/PerformanceEntry.h View 1 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/timing/PerformanceEntry.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/timing/PerformanceMark.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/timing/PerformanceMeasure.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/timing/PerformanceNavigation.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/timing/PerformanceResourceTiming.h View 1 3 chunks +6 lines, -7 lines 0 comments Download
M Source/core/timing/PerformanceResourceTiming.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/timing/PerformanceTiming.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/timing/PerformanceUserTiming.h View 1 3 chunks +7 lines, -10 lines 0 comments Download
M Source/core/timing/PerformanceUserTiming.cpp View 1 2 chunks +1 line, -4 lines 0 comments Download
M Source/modules/performance/WorkerPerformance.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M Source/modules/performance/WorkerPerformance.cpp View 1 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
sof
Please take a look.
5 years, 8 months ago (2015-04-22 08:25:04 UTC) #2
haraken
LGTM https://codereview.chromium.org/693483004/diff/20001/Source/core/timing/DOMWindowPerformance.h File Source/core/timing/DOMWindowPerformance.h (right): https://codereview.chromium.org/693483004/diff/20001/Source/core/timing/DOMWindowPerformance.h#newcode35 Source/core/timing/DOMWindowPerformance.h:35: // TODO(sof): try to move this direct reference ...
5 years, 8 months ago (2015-04-22 11:17:25 UTC) #4
sof
Thanks; this makes the following script-exposed objects be on the heap with !ENABLE(OILPAN): - MemoryInfo ...
5 years, 8 months ago (2015-04-22 11:41:36 UTC) #5
haraken
On 2015/04/22 11:41:36, sof wrote: > Thanks; this makes the following script-exposed objects be on ...
5 years, 8 months ago (2015-04-22 11:58:07 UTC) #6
haraken
https://codereview.chromium.org/693483004/diff/20001/Source/core/timing/Performance.h File Source/core/timing/Performance.h (right): https://codereview.chromium.org/693483004/diff/20001/Source/core/timing/Performance.h#newcode107 Source/core/timing/Performance.h:107: WeakMember<MemoryInfo> m_memoryInfo; On 2015/04/22 11:41:36, sof wrote: > On ...
5 years, 8 months ago (2015-04-22 11:58:13 UTC) #7
sof
If the Oilpan bots come through green also, proceed to land? https://codereview.chromium.org/693483004/diff/20001/Source/core/timing/Performance.h File Source/core/timing/Performance.h (right): ...
5 years, 8 months ago (2015-04-22 14:36:14 UTC) #8
haraken
> If the Oilpan bots come through green also, proceed to land? I think it's ...
5 years, 8 months ago (2015-04-22 15:30:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693483004/40001
5 years, 8 months ago (2015-04-22 17:58:38 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=194227
5 years, 8 months ago (2015-04-22 18:05:12 UTC) #13
aboxhall
Any chance this could have caused these test failures? https://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/25605
5 years, 8 months ago (2015-04-23 00:17:55 UTC) #14
haraken
5 years, 8 months ago (2015-04-23 04:20:59 UTC) #15
Message was sent while issue was closed.
On 2015/04/23 00:17:55, aboxhall wrote:
> Any chance this could have caused these test failures?
>
https://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28db...

I don't think it's related, but why do you think this CL is suspicios?

Powered by Google App Engine
This is Rietveld 408576698