| OLD | NEW |
| 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #include "tools/gn/ninja_copy_target_writer.h" | 5 #include "tools/gn/ninja_copy_target_writer.h" |
| 6 | 6 |
| 7 #include "base/strings/string_util.h" | 7 #include "base/strings/string_util.h" |
| 8 #include "tools/gn/ninja_utils.h" | 8 #include "tools/gn/ninja_utils.h" |
| 9 #include "tools/gn/output_file.h" | 9 #include "tools/gn/output_file.h" |
| 10 #include "tools/gn/scheduler.h" | 10 #include "tools/gn/scheduler.h" |
| (...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 64 const SubstitutionList& output_subst_list = | 64 const SubstitutionList& output_subst_list = |
| 65 target_->action_values().outputs(); | 65 target_->action_values().outputs(); |
| 66 CHECK_EQ(1u, output_subst_list.list().size()) | 66 CHECK_EQ(1u, output_subst_list.list().size()) |
| 67 << "Should have one entry exactly."; | 67 << "Should have one entry exactly."; |
| 68 const SubstitutionPattern& output_subst = output_subst_list.list()[0]; | 68 const SubstitutionPattern& output_subst = output_subst_list.list()[0]; |
| 69 | 69 |
| 70 std::string tool_name = | 70 std::string tool_name = |
| 71 GetNinjaRulePrefixForToolchain(settings_) + | 71 GetNinjaRulePrefixForToolchain(settings_) + |
| 72 Toolchain::ToolTypeToName(Toolchain::TYPE_COPY); | 72 Toolchain::ToolTypeToName(Toolchain::TYPE_COPY); |
| 73 | 73 |
| 74 OutputFile input_dep = |
| 75 WriteInputDepsStampAndGetDep(std::vector<const Target*>()); |
| 76 |
| 74 // Note that we don't write implicit deps for copy steps. "copy" only | 77 // Note that we don't write implicit deps for copy steps. "copy" only |
| 75 // depends on the output files themselves, rather than having includes | 78 // depends on the output files themselves, rather than having includes |
| 76 // (the possibility of generated #includes is the main reason for implicit | 79 // (the possibility of generated #includes is the main reason for implicit |
| 77 // dependencies). | 80 // dependencies). |
| 78 // | 81 // |
| 79 // It would seem that specifying implicit dependencies on the deps of the | 82 // It would seem that specifying implicit dependencies on the deps of the |
| 80 // copy command would still be harmeless. But Chrome implements copy tools | 83 // copy command would still be harmeless. But Chrome implements copy tools |
| 81 // as hard links (much faster) which don't change the timestamp. If the | 84 // as hard links (much faster) which don't change the timestamp. If the |
| 82 // ninja rule looks like this: | 85 // ninja rule looks like this: |
| 83 // output: copy input | foo.stamp | 86 // output: copy input | foo.stamp |
| 84 // The copy will not make a new timestamp on the output file, but the | 87 // The copy will not make a new timestamp on the output file, but the |
| 85 // foo.stamp file generated from a previous step will have a new timestamp. | 88 // foo.stamp file generated from a previous step will have a new timestamp. |
| 86 // The copy rule will therefore look out-of-date to Ninja and the rule will | 89 // The copy rule will therefore look out-of-date to Ninja and the rule will |
| 87 // get rebuilt. | 90 // get rebuilt. |
| 88 // | 91 // |
| 89 // If this copy is copying a generated file, not listing the implicit | 92 // If this copy is copying a generated file, not listing the implicit |
| 90 // dependency will be fine as long as the input to the copy is properly | 93 // dependency will be fine as long as the input to the copy is properly |
| 91 // listed as the output from the step that generated it. | 94 // listed as the output from the step that generated it. |
| 92 // | 95 // |
| 93 // Moreover, doing this assumes that the copy step is always a simple | 96 // Moreover, doing this assumes that the copy step is always a simple |
| 94 // locally run command, so there is no need for a toolchain dependency. | 97 // locally run command, so there is no need for a toolchain dependency. |
| 98 // |
| 99 // Note that there is the need in some cases for order-only dependencies |
| 100 // where a command might need to make sure something else runs before it runs |
| 101 // to avoid conflicts. Such cases should be avoided where possible, but |
| 102 // sometimes that's not possible. |
| 95 for (size_t i = 0; i < target_->sources().size(); i++) { | 103 for (size_t i = 0; i < target_->sources().size(); i++) { |
| 96 const SourceFile& input_file = target_->sources()[i]; | 104 const SourceFile& input_file = target_->sources()[i]; |
| 97 | 105 |
| 98 OutputFile output_file = | 106 OutputFile output_file = |
| 99 SubstitutionWriter::ApplyPatternToSourceAsOutputFile( | 107 SubstitutionWriter::ApplyPatternToSourceAsOutputFile( |
| 100 target_->settings(), output_subst, input_file); | 108 target_->settings(), output_subst, input_file); |
| 101 output_files->push_back(output_file); | 109 output_files->push_back(output_file); |
| 102 | 110 |
| 103 out_ << "build "; | 111 out_ << "build "; |
| 104 path_output_.WriteFile(out_, output_file); | 112 path_output_.WriteFile(out_, output_file); |
| 105 out_ << ": " << tool_name << " "; | 113 out_ << ": " << tool_name << " "; |
| 106 path_output_.WriteFile(out_, input_file); | 114 path_output_.WriteFile(out_, input_file); |
| 115 if (!input_dep.value().empty()) { |
| 116 out_ << " || "; |
| 117 path_output_.WriteFile(out_, input_dep); |
| 118 } |
| 107 out_ << std::endl; | 119 out_ << std::endl; |
| 108 } | 120 } |
| 109 } | 121 } |
| OLD | NEW |