Fix autofill popup size.

Fix autofill popup size.

This is expanded to 64 pixels tall so that it will be presented correctly, but we want to avoid telling the content about that.

BUG=320974
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236409

[Ben Goodger (Google), 2013-11-20 21:50:44]

https://codereview.chromium.org/69343016/diff/1/ui/aura/root_window.cc
File ui/aura/root_window.cc (right):

https://codereview.chromium.org/69343016/diff/1/ui/aura/root_window.cc#newcod...
ui/aura/root_window.cc:836: UpdateRootWindowSize(window_size);
What does GetBounds() return if the window is minimized? the last size before
the minimization?

[jbauman, 2013-11-20 22:01:43]

On 2013/11/20 21:50:44, Ben Goodger (Google) wrote:
> https://codereview.chromium.org/69343016/diff/1/ui/aura/root_window.cc
> File ui/aura/root_window.cc (right):
> 
>
https://codereview.chromium.org/69343016/diff/1/ui/aura/root_window.cc#newcod...
> ui/aura/root_window.cc:836: UpdateRootWindowSize(window_size);
> What does GetBounds() return if the window is minimized? the last size before
> the minimization?

I'm not really sure. I think it returns a garbage size (ClientAreaSizeChanged
has a comment mentioning that). Maybe we should fix that?

[jbauman, 2013-11-20 23:53:49]

On 2013/11/20 22:01:43, jbauman wrote:
> On 2013/11/20 21:50:44, Ben Goodger (Google) wrote:
> > https://codereview.chromium.org/69343016/diff/1/ui/aura/root_window.cc
> > File ui/aura/root_window.cc (right):
> > 
> >
>
https://codereview.chromium.org/69343016/diff/1/ui/aura/root_window.cc#newcod...
> > ui/aura/root_window.cc:836: UpdateRootWindowSize(window_size);
> > What does GetBounds() return if the window is minimized? the last size
before
> > the minimization?
> 
> I'm not really sure. I think it returns a garbage size (ClientAreaSizeChanged
> has a comment mentioning that). Maybe we should fix that?

PTAL. I've fixed GetBounds to return a 0x0 rect if the window's minimized (which
matches HWNDMessageHandler::ClientAreaSizeChanged(), as the comment says).

[Ben Goodger (Google), 2013-11-21 02:42:17]

lgtm

[commit-bot: I haz the power, 2013-11-21 03:13:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jbauman@chromium.org/69343016/90002

[commit-bot: I haz the power, 2013-11-21 06:22:09]

Change committed as 236409

[dcheng, 2013-11-21 08:16:05]

On 2013/11/21 06:22:09, I haz the power (commit-bot) wrote:
> Change committed as 236409

This might be causing issues on the Win8 aura bots, for example see
http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/12843

BaseLayoutManagerTest.MaximizeRootWindowResize: 
wm\base_layout_manager_unittest.cc(141): error: Value of:
window->bounds().ToString()
Actual: "0,0 800x553"
Expected: ScreenAsh::GetMaximizedWindowBoundsInParent(window.get()).ToString()
Which is: "0,0 900x653"
[1780:892:1120/225834:1142301:INFO:test_metro_viewer_process_host.cc(31)]
ash::test::TestMetroViewerProcessHost::OnSetTargetSurface, target_surface =
11666048