visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/XamlParser.cs - Issue 69343013: [VS AddIn] Fix default library paths.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/XamlParser.cs

Issue 69343013: [VS AddIn] Fix default library paths. (Closed) Base URL: https://nativeclient-sdk.googlecode.com/svn/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClLink.cs ('k') | visual_studio/NativeClientVSAddIn/UnitTests/BaseCompileTest.cs » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/XamlParser.cs

diff --git a/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/XamlParser.cs b/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/XamlParser.cs

index 652cab92bd0f3291c5e56c65cbf8d50b6f51a06b..b2b3be16eee2a41e6fcd237911c707d007d85668 100644

--- a/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/XamlParser.cs

+++ b/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/XamlParser.cs

@@ -49,13 +49,17 @@ namespace NaCl.Build.CPPTasks

};

}

- public string Parse(ITaskItem taskItem, bool fullOutputName)

+ public string Parse(ITaskItem taskItem, bool fullOutputName, string outputExtension)

{

CommandLineBuilder builder = new CommandLineBuilder();

foreach (string name in taskItem.MetadataNames)

{

string value = taskItem.GetMetadata(name);

+ if (outputExtension != null && name == "OutputFile")

+ {

+ value = Path.ChangeExtension(value, outputExtension);

+ }

if (fullOutputName && name == "ObjectFileName")

{

if ((File.GetAttributes(value) & FileAttributes.Directory) != 0)