Chromium Code Reviews| Index: visual_studio/NativeClientVSAddIn/UnitTests/BaseCompileTest.cs |
| diff --git a/visual_studio/NativeClientVSAddIn/UnitTests/BaseCompileTest.cs b/visual_studio/NativeClientVSAddIn/UnitTests/BaseCompileTest.cs |
| index 03959c31bb8f61b8df4808a091def5c98d8a9fe9..be46d2d15ec6093d0090f1970e7d68c46bfa4bc4 100644 |
| --- a/visual_studio/NativeClientVSAddIn/UnitTests/BaseCompileTest.cs |
| +++ b/visual_studio/NativeClientVSAddIn/UnitTests/BaseCompileTest.cs |
| @@ -106,16 +106,21 @@ namespace UnitTests |
| TestUtilities.SetProjectType(project, projectType, platformName); |
| } |
| - protected void CheckCompile(string platform, bool dll) |
| + protected void CheckCompile(string platform) |
| { |
| + bool ppapi = platform == Strings.PepperPlatformName; |
| dte_.Solution.Open(SolutionName_); |
| - SetProjectType("Executable", platform); |
| - TryCompile("Debug", platform); |
| - TryCompile("Release", platform); |
| + if (!ppapi) |
| + { |
| + // PPAPI host build are always either dll's or static libraries. |
| + SetProjectType("Application", platform); |
|
binji
2013/11/19 21:57:16
you changed Executable -> Application... what's th
Sam Clegg
2013/11/19 23:21:24
This was the main bug. "Executable" is not a vali
|
| + TryCompile("Debug", platform); |
| + TryCompile("Release", platform); |
| + } |
| SetProjectType("StaticLibrary", platform); |
| TryCompile("Debug", platform); |
| TryCompile("Release", platform); |
| - if (dll) |
| + if (ppapi) |
| { |
| SetProjectType("DynamicLibrary", platform); |
| TryCompile("Debug", platform); |