visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs - Issue 69343013: [VS AddIn] Fix default library paths.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs

Issue 69343013: [VS AddIn] Fix default library paths. (Closed) Base URL: https://nativeclient-sdk.googlecode.com/svn/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/NaCl.Paths.default.props ('K') | « visual_studio/NativeClientVSAddIn/InstallerResources/NaCl/NaCl.Paths.default.props ('k') | visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClLink.cs » ('j') | visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClLink.cs » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs

diff --git a/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs b/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs

index 383876425969334df4fe885401d5fdde9de1f684..71725dfe66d377293aa364222165e4c81c7b8ba2 100644

--- a/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs

+++ b/visual_studio/NativeClientVSAddIn/NaCl.Build.CPPTasks/NaClCompile.cs

@@ -193,7 +193,7 @@ namespace NaCl.Build.CPPTasks

StringBuilder commandLine = new StringBuilder(GCCUtilities.s_CommandLineLength);

//build command line from components and add required switches

- string props = xamlParser.Parse(sourceFile, fullOutputName);

+ string props = xamlParser.Parse(sourceFile, fullOutputName, null);

commandLine.Append(props);

commandLine.Append(" -c");