Issue 69343003: Use a HashCountedSet to count identifiers in InspectorConsoleAgent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 69343003: Use a HashCountedSet to count identifiers in InspectorConsoleAgent (Closed)

Created:
7 years, 1 month ago by Inactive

Modified:
7 years, 1 month ago

Reviewers:
pfeldman, eseidel

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Use a HashCountedSet to count identifiers in InspectorConsoleAgent Use a HashCountedSet to count identifiers in InspectorConsoleAgent instead of handling the counting manually and using a HashMap data structure. This abstracts away some of the complexity and makes the code a bit simpler. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161811

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -13 lines)			Patch
	M	Source/core/inspector/InspectorConsoleAgent.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	Source/core/inspector/InspectorConsoleAgent.cpp	View		1 chunk	+2 lines, -12 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/69343003/1

7 years, 1 month ago (2013-11-11 22:21:45 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/69343003/1

7 years, 1 month ago (2013-11-12 13:52:50 UTC) #4

Message was sent while issue was closed.

Change committed as 161811

Expand Messages | Collapse Messages