Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 693423002: Devirtualize animatedLocalTransform() and rename it for clarity (Closed)

Created:
6 years, 1 month ago by pdr.
Modified:
6 years, 1 month ago
CC:
blink-reviews, blink-reviews-rendering, krit, eae+blinkwatch, ed+blinkwatch_opera.com, f(malita), fs, gyuyoung.kim_webkit.org, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, zoltan1
Project:
blink
Visibility:
Public.

Description

Devirtualize animatedLocalTransform() and rename it for clarity This patch devirtualizes animatedLocalTransform and renames it calculateAnimatedLocalTransform to emphasize that it is not cheap. SVGGraphicsElement::animatedLocalTransform was virtual to support SVGTextElement's special transform code. The text-specific transform code is only in an infrequently-taken codepath (style && style->hasTransform()) so we can actually improve performance by devirtalizing and combining the two transform codepaths. The real benefit is code simplification though. Secondly, I've renamed this function to make it clear that it is not a simple lookup. BUG=429551 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184845

Patch Set 1 #

Patch Set 2 : Remove some codes that snuck in #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -57 lines) Patch
M Source/core/rendering/svg/RenderSVGForeignObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceClipper.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGShape.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGTextPath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGTransformableContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGraphicsElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/svg/SVGGraphicsElement.cpp View 3 chunks +23 lines, -18 lines 0 comments Download
M Source/core/svg/SVGTextElement.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/svg/SVGTextElement.cpp View 1 chunk +0 lines, -25 lines 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
pdr.
6 years, 1 month ago (2014-11-03 01:32:33 UTC) #2
Stephen Chennney
Looks fine to me. Took me a while to verify the code does the same ...
6 years, 1 month ago (2014-11-04 19:00:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693423002/20001
6 years, 1 month ago (2014-11-04 20:48:50 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 00:12:24 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184845

Powered by Google App Engine
This is Rietveld 408576698