chrome/browser/resources/options/hotword_search_setting_indicator.css - Issue 693393004: Add error indicators to always-on andno-dsp hotword checkboxes.

Side by Side Diff: chrome/browser/resources/options/hotword_search_setting_indicator.css

Issue 693393004: Add error indicators to always-on andno-dsp hotword checkboxes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove error conditions used for testing Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/options/browser_options.js ('k') | chrome/browser/ui/webui/options/browser_options_handler.cc » ('j') | chrome/browser/ui/webui/options/browser_options_handler.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /* Copyright 2014 The Chromium Authors. All rights reserved.	1 /* Copyright 2014 The Chromium Authors. All rights reserved.

2 * Use of this source code is governed by a BSD-style license that can be	2 * Use of this source code is governed by a BSD-style license that can be

3 * found in the LICENSE file. */	3 * found in the LICENSE file. */

4	4

5 /* Hotword extension-specific controlled setting indicator and bubble. */	5 /* Hotword extension-specific controlled setting indicator and bubble. */

6	6

7 #hotword-search-setting-indicator > div {	7 #hotword-search-setting-indicator > div {

8 background: url('chrome://theme/IDR_WARNING') left top no-repeat;	8 background: url('chrome://theme/IDR_WARNING') left top no-repeat;

9 background-size: 18px;	9 background-size: 18px;

10 }	10 }

	11 #hotword-always-on-search-setting-indicator > div {
	rpetterson 2014/11/03 18:14:16 wondering if there's a way to combine these three wondering if there's a way to combine these three with css magic. Dan might have an idea. kcarattini 2014/11/03 23:39:24 Yeah, using a class gets overridden by the control Show quoted text On 2014/11/03 18:14:16, rpetterson wrote: > wondering if there's a way to combine these three with css magic. Dan might have > an idea. Yeah, using a class gets overridden by the controlled-setting-indicator, I think. Dan Beam 2014/11/04 01:59:24 read up on CSS specificity: https://developer.mozi Show quoted text On 2014/11/03 23:39:24, kcarattini wrote: > On 2014/11/03 18:14:16, rpetterson wrote: > > wondering if there's a way to combine these three with css magic. Dan might > have > > an idea. > > Yeah, using a class gets overridden by the controlled-setting-indicator, I > think. read up on CSS specificity: https://developer.mozilla.org/en-US/docs/Web/CSS/Specificity if a class simply wont do it for you, here's an alternative: #hotword-search-setting-indicator > div, #hotword-always-on-search-setting-indicator > div, #hotword-no-dsp-search-setting-indicator > div { background: url(chrome://theme/IDR_WARNING) left top no-repeat; background-size: 18px; } kcarattini 2014/11/04 06:01:20 Done. Show quoted text On 2014/11/04 01:59:24, Dan Beam wrote: > On 2014/11/03 23:39:24, kcarattini wrote: > > On 2014/11/03 18:14:16, rpetterson wrote: > > > wondering if there's a way to combine these three with css magic. Dan might > > have > > > an idea. > > > > Yeah, using a class gets overridden by the controlled-setting-indicator, I > > think. > > read up on CSS specificity: > https://developer.mozilla.org/en-US/docs/Web/CSS/Specificity > > if a class simply wont do it for you, here's an alternative: > > #hotword-search-setting-indicator > div, > #hotword-always-on-search-setting-indicator > div, > #hotword-no-dsp-search-setting-indicator > div { > background: url(chrome://theme/IDR_WARNING) left top no-repeat; > background-size: 18px; > } Done.
	12 background: url('chrome://theme/IDR_WARNING') left top no-repeat;

	13 background-size: 18px;

	14 }

	15 #hotword-no-dsp-search-setting-indicator > div {

	16 background: url('chrome://theme/IDR_WARNING') left top no-repeat;

	17 background-size: 18px;

	18 }

OLD	NEW