Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Side by Side Diff: chrome/browser/resources/options/browser_options.html

Issue 693393004: Add error indicators to always-on andno-dsp hotword checkboxes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review Comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/options/browser_options.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <div id="settings" class="page" hidden> 1 <div id="settings" class="page" hidden>
2 <header> 2 <header>
3 <h1 i18n-content="settingsTitle"></h1> 3 <h1 i18n-content="settingsTitle"></h1>
4 </header> 4 </header>
5 <include src="reset_profile_settings_banner.html"> 5 <include src="reset_profile_settings_banner.html">
6 <include src="automatic_settings_reset_banner.html"> 6 <include src="automatic_settings_reset_banner.html">
7 <if expr="chromeos"> 7 <if expr="chromeos">
8 <include src="secondary_user_banner.html"> 8 <include src="secondary_user_banner.html">
9 <section> 9 <section>
10 <div id="network-section-header" class="section-header"> 10 <div id="network-section-header" class="section-header">
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 <div class="checkbox controlled-setting-with-label"> 161 <div class="checkbox controlled-setting-with-label">
162 <label> 162 <label>
163 <input id="hotword-always-on-search-checkbox" 163 <input id="hotword-always-on-search-checkbox"
164 pref="hotword.always_on_search_enabled" type="checkbox"> 164 pref="hotword.always_on_search_enabled" type="checkbox">
165 <span i18n-content="hotwordSearchEnable"></span> 165 <span i18n-content="hotwordSearchEnable"></span>
166 </label> 166 </label>
167 <a target="_blank" class="hotword-learn-more-link" 167 <a target="_blank" class="hotword-learn-more-link"
168 i18n-content="learnMore" 168 i18n-content="learnMore"
169 i18n-values="href:hotwordLearnMoreURL"> 169 i18n-values="href:hotwordLearnMoreURL">
170 </a> 170 </a>
171 <span id="hotword-always-on-search-setting-indicator"
172 pref="hotword.always_on_search_enabled" dialog-pref></span>
171 <div> 173 <div>
172 <span class="hotword-description" 174 <span class="hotword-description"
173 i18n-content="hotwordAlwaysOnDesc"> 175 i18n-content="hotwordAlwaysOnDesc">
174 </span> 176 </span>
175 </div> 177 </div>
176 </div> 178 </div>
177 </div> 179 </div>
178 <div id="hotword-no-dsp-search" hidden> 180 <div id="hotword-no-dsp-search" hidden>
179 <div class="checkbox controlled-setting-with-label"> 181 <div class="checkbox controlled-setting-with-label">
180 <label> 182 <label>
181 <input id="hotword-no-dsp-search-checkbox" 183 <input id="hotword-no-dsp-search-checkbox"
182 pref="hotword.search_enabled_2" type="checkbox"> 184 pref="hotword.search_enabled_2" type="checkbox">
183 <span i18n-content="hotwordSearchEnable"></span> 185 <span i18n-content="hotwordSearchEnable"></span>
184 </label> 186 </label>
185 <a target="_blank" class="hotword-learn-more-link" 187 <a target="_blank" class="hotword-learn-more-link"
186 i18n-content="learnMore" 188 i18n-content="learnMore"
187 i18n-values="href:hotwordLearnMoreURL"> 189 i18n-values="href:hotwordLearnMoreURL">
188 </a> 190 </a>
191 <span id="hotword-no-dsp-search-setting-indicator"
192 pref="hotword.search_enabled_2" dialog-pref></span>
189 <div> 193 <div>
190 <span class="hotword-description" 194 <span class="hotword-description"
191 i18n-content="hotwordNoDSPDesc"> 195 i18n-content="hotwordNoDSPDesc">
192 </span> 196 </span>
193 </div> 197 </div>
194 </div> 198 </div>
195 </div> 199 </div>
196 <div id="audio-logging" hidden> 200 <div id="audio-logging" hidden>
197 <div class="checkbox controlled-setting-with-label"> 201 <div class="checkbox controlled-setting-with-label">
198 <label> 202 <label>
(...skipping 754 matching lines...) Expand 10 before | Expand all | Expand 10 after
953 </button> 957 </button>
954 </div> 958 </div>
955 </section> 959 </section>
956 </div> <!-- advanced-settings-container --> 960 </div> <!-- advanced-settings-container -->
957 </div> <!-- advanced-settings --> 961 </div> <!-- advanced-settings -->
958 <footer> 962 <footer>
959 <a is="action-link" id="advanced-settings-expander" 963 <a is="action-link" id="advanced-settings-expander"
960 i18n-content="showAdvancedSettings"></a> 964 i18n-content="showAdvancedSettings"></a>
961 </footer> 965 </footer>
962 </div> 966 </div>
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/options/browser_options.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698