Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 693393003: Subzero: Allow non-hybrid binaries to be built. (Closed)

Created:
6 years, 1 month ago by Jim Stichnoth
Modified:
6 years, 1 month ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Subzero: Allow non-hybrid binaries to be built. Build a pure-Subzero binary when neither --include nor --exclude is specified. A pure-Subzero binary is built without flags: -externalize -ffunction-sections -fdata-sections which is good because that configuration is closer to what real usage will be, and will get more testing during development. BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=58acae3eeb6102b8567173d4c219adb9ec93a18a

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -78 lines) Patch
M pydir/szbuild.py View 6 chunks +94 lines, -78 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
Jim Stichnoth
https://codereview.chromium.org/693393003/diff/1/pydir/szbuild.py File pydir/szbuild.py (left): https://codereview.chromium.org/693393003/diff/1/pydir/szbuild.py#oldcode99 pydir/szbuild.py:99: By default, for every symbol, its llc version is ...
6 years, 1 month ago (2014-11-02 19:11:48 UTC) #2
Karl
lgtm
6 years, 1 month ago (2014-11-03 16:55:01 UTC) #3
Jim Stichnoth
6 years, 1 month ago (2014-11-03 20:31:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
58acae3eeb6102b8567173d4c219adb9ec93a18a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698