Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1066)

Issue 693313003: Factor SVGMarkerPainter into SVGShapePainter (Closed)

Created:
6 years, 1 month ago by pdr.
Modified:
6 years, 1 month ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Factor SVGMarkerPainter into SVGShapePainter SVGShapePainter is the only class to paint markers so the marker painter class is all overhead. This patch moves the marker painter code into SVGShapePainter. BUG=412088 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184895

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -67 lines) Patch
M Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D Source/core/paint/SVGMarkerPainter.h View 1 chunk +0 lines, -26 lines 0 comments Download
D Source/core/paint/SVGMarkerPainter.cpp View 1 chunk +0 lines, -37 lines 0 comments Download
M Source/core/paint/SVGShapePainter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/paint/SVGShapePainter.cpp View 2 chunks +23 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pdr.
6 years, 1 month ago (2014-11-06 02:41:54 UTC) #2
chrishtr
lgtm
6 years, 1 month ago (2014-11-06 02:56:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693313003/1
6 years, 1 month ago (2014-11-06 02:57:00 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-06 04:17:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184895

Powered by Google App Engine
This is Rietveld 408576698