Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 693263003: Fixed some crashes when playing media from the blob URL. (Closed)

Created:
6 years, 1 month ago by mlopatkin
Modified:
6 years, 1 month ago
Reviewers:
qinmin
CC:
chromium-reviews, darin-cc_chromium.org, jam, avayvod+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixed some crashes when playing media from the blob URL. The first problem that causes DCHECK failure is the access to Profile from the IO thread. We should pass IO-thread-safe ResourceContext instead of passing UI-thread confined BrowserContext (i.e. Profile). We also must handle cases when blob URL resolves to NULL handle. There are plenty of cases when this is true: the URL may be invalid or already revoked, blob decoding may fail and so on. BUG=429432 Committed: https://crrev.com/61cb84971f5f21eb83b7e3b3ac43364aafb9b2d4 Cr-Commit-Position: refs/heads/master@{#302775}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M content/browser/media/android/media_resource_getter_impl.cc View 3 chunks +15 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mlopatkin
Hello, please take a look, this patch aims to fix some crashes when trying to ...
6 years, 1 month ago (2014-11-01 16:35:18 UTC) #2
qinmin
lgtm
6 years, 1 month ago (2014-11-03 19:45:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693263003/1
6 years, 1 month ago (2014-11-05 09:45:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-05 10:29:46 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 10:30:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61cb84971f5f21eb83b7e3b3ac43364aafb9b2d4
Cr-Commit-Position: refs/heads/master@{#302775}

Powered by Google App Engine
This is Rietveld 408576698