Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Issue 693243002: Remove interactive content and form related API from HTMLElement. (Closed)

Created:
6 years, 1 month ago by esprehn
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove interactive content and form related API from HTMLElement. In particular this inlines the accessKeyAction, removes isInteractiveContent() which was for special casing certain elements in event dispatch, and removes eventParameterName() which was only needed for inline event handlers. I also moved Node::commonAncestor into NodeRenderingTraversal, the only callers of it passed NodeRenderingTraversal::parent as the second argument, it didn't make sense to have this generic thing. R=abarth@chromium.org, ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5d43fbe8141fe679cdb3f0e0fbd1eef4690cece2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -94 lines) Patch
M sky/engine/core/dom/Element.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Node.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/Node.cpp View 1 chunk +0 lines, -37 lines 0 comments Download
M sky/engine/core/dom/NodeRenderingTraversal.h View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/core/dom/NodeRenderingTraversal.cpp View 1 chunk +37 lines, -0 lines 0 comments Download
M sky/engine/core/html/HTMLAnchorElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/HTMLAnchorElement.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/html/HTMLElement.h View 1 chunk +0 lines, -8 lines 0 comments Download
M sky/engine/core/html/HTMLElement.cpp View 2 chunks +0 lines, -16 lines 0 comments Download
M sky/engine/core/html/HTMLImageElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/HTMLImageElement.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/html/HTMLMediaElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/HTMLMediaElement.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/page/EventHandler.cpp View 4 chunks +5 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
6 years, 1 month ago (2014-11-01 01:21:18 UTC) #1
abarth-chromium
lgtm
6 years, 1 month ago (2014-11-01 01:36:04 UTC) #3
esprehn
6 years, 1 month ago (2014-11-01 01:48:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5d43fbe8141fe679cdb3f0e0fbd1eef4690cece2.

Powered by Google App Engine
This is Rietveld 408576698