Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 693213002: Bisect Mac performance regression. (Closed)

Created:
6 years, 1 month ago by bungeman-skia
Modified:
6 years, 1 month ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

With https://chromium.googlesource.com/skia/+/43b8b36b20ae00e2d78421c4cda1f3f922983a20 blink_perf.layout regressed. It appears that the typeface cache is being missed. This is a partial revert of the Skia change which reverts the smallest amount of code to restore performance. BUG=chromium:425566 Committed: https://skia.googlesource.com/skia/+/47eda52e8fb88f0725b401762a3e0bddc98e9fb3 Committed: https://skia.googlesource.com/skia/+/336fdf2c5fad1cb0d7f51c16c2e13e7c75e0afd3

Patch Set 1 #

Patch Set 2 : Bisect2 #

Patch Set 3 : Bisect3 #

Patch Set 4 : Bisect4 #

Patch Set 5 : Bisect4 (fixed) #

Patch Set 6 : Bisect5 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -25 lines) Patch
M src/ports/SkFontHost_mac.cpp View 1 2 3 4 5 8 chunks +24 lines, -25 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
bungeman-skia
This should restore Mac performance until we can fix up the typeface cache.
6 years, 1 month ago (2014-11-04 17:08:07 UTC) #2
reed1
lgtm do we have a good understanding of the cache misses in general?
6 years, 1 month ago (2014-11-04 17:45:41 UTC) #3
bungeman-skia
On 2014/11/04 17:45:41, reed1 wrote: > lgtm > > do we have a good understanding ...
6 years, 1 month ago (2014-11-04 18:19:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693213002/100001
6 years, 1 month ago (2014-11-04 18:20:08 UTC) #6
commit-bot: I haz the power
Committed patchset #6 (id:100001) as 47eda52e8fb88f0725b401762a3e0bddc98e9fb3
6 years, 1 month ago (2014-11-04 18:27:39 UTC) #7
egdaniel
A revert of this CL (patchset #6 id:100001) has been created in https://codereview.chromium.org/683753003/ by egdaniel@google.com. ...
6 years, 1 month ago (2014-11-05 15:39:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693213002/100001
6 years, 1 month ago (2014-11-10 15:48:50 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 15:49:00 UTC) #11
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/336fdf2c5fad1cb0d7f51c16c2e13e7c75e0afd3

Powered by Google App Engine
This is Rietveld 408576698