Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 693203004: Revert of Adding Element.closest() API (Closed)

Created:
6 years, 1 month ago by pdr.
Modified:
6 years, 1 month ago
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Adding Element.closest() API (patchset #1 id:1 of https://codereview.chromium.org/704733002/) Reason for revert: Merged patch from WebKit contains errors. Original issue's description: > Adding Element.closest() API > > Implementing Element.closest() API according to specs > https://dom.spec.whatwg.org/#dom-element-closest > > This API will parse selectors and if fails then throw SyntaxError > else return closest ancestor that matches selectors > if there is no ancestor that matches selectors, it will > return nullptr. > > Blink-Dev Intent to Implement and ship Link : > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/yk_Fo6hyvb8 > > WebKit Change: http://trac.webkit.org/changeset/174324 > > BUG=422731 > R=habib.virji@samsung.com > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184946 TBR=habib.virji@samsung.com,rune@opera.com,l.gombos@samsung.com,paritosh.in@samsung.com NOTREECHECKS=true NOTRY=true BUG=422731 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184992

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -202 lines) Patch
D LayoutTests/fast/selectors/element-closeset.html View 1 chunk +0 lines, -120 lines 0 comments Download
D LayoutTests/fast/selectors/element-closeset-expected.txt View 1 chunk +0 lines, -67 lines 0 comments Download
M Source/core/dom/Element.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
pdr.
Created Revert of Adding Element.closest() API
6 years, 1 month ago (2014-11-07 22:28:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693203004/1
6 years, 1 month ago (2014-11-07 22:28:53 UTC) #2
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 22:29:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184992

Powered by Google App Engine
This is Rietveld 408576698