Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 693203003: Pass device_id/device_type to web flow token approval url. (Closed)

Created:
6 years, 1 month ago by pavely
Modified:
6 years, 1 month ago
Reviewers:
Michael Courage
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Pass device_id/device_type to web flow token approval url. The issue is after enabling sending device_id for LST, IssueToken endpoint started returning "issueAdvice": "consent" for scope marked with per_device_authorization_required:true. The solution is to pass the same device_id/device_type to approval url. Tests: Tested that for LST with device_id consent screen is only shown once. After restart access token is issued without user interaction. Tested that for LST without device_id no consent screen is shown. BUG=403718 R=courage@chromium.org Committed: https://crrev.com/f0efb899fdc7c72a8fcc6eaf717dad6b03beab27 Cr-Commit-Position: refs/heads/master@{#302350}

Patch Set 1 #

Patch Set 2 : Fix unittests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -9 lines) Patch
M chrome/browser/extensions/api/identity/gaia_web_auth_flow.cc View 1 3 chunks +26 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
pavely
Michael, please take a look.
6 years, 1 month ago (2014-10-31 20:43:46 UTC) #1
Michael Courage
lgtm
6 years, 1 month ago (2014-10-31 20:51:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693203003/1
6 years, 1 month ago (2014-10-31 20:57:14 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/7524)
6 years, 1 month ago (2014-10-31 22:04:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693203003/20001
6 years, 1 month ago (2014-10-31 22:08:18 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-31 23:24:15 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 23:25:31 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f0efb899fdc7c72a8fcc6eaf717dad6b03beab27
Cr-Commit-Position: refs/heads/master@{#302350}

Powered by Google App Engine
This is Rietveld 408576698