Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Unified Diff: pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart

Issue 693183006: Revert "Move dart2js from sdk/lib/_internal/compiler to pkg/compiler" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart
diff --git a/pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart b/pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart
deleted file mode 100644
index 91b4a399e545526cd65a61bdb9e5cd3afb26636d..0000000000000000000000000000000000000000
--- a/pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart
+++ /dev/null
@@ -1,76 +0,0 @@
-// Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
-// for details. All rights reserved. Use of this source code is governed by a
-// BSD-style license that can be found in the LICENSE file.
-
-library dart2js.new_js_emitter.emitter;
-
-import '../model.dart';
-import 'model_emitter.dart';
-import '../../common.dart';
-import '../../js/js.dart' as js;
-
-import '../../js_backend/js_backend.dart' show Namer, JavaScriptBackend;
-import '../../js_emitter/js_emitter.dart' as emitterTask show
- CodeEmitterTask,
- Emitter;
-
-class Emitter implements emitterTask.Emitter {
- final Compiler _compiler;
- final Namer namer;
- final ModelEmitter _emitter;
-
- Emitter(Compiler compiler, Namer namer)
- : this._compiler = compiler,
- this.namer = namer,
- _emitter = new ModelEmitter(compiler, namer);
-
- void emitProgram(Program program) {
- _emitter.emitProgram(program);
- }
-
- // TODO(floitsch): copied from OldEmitter. Adjust or share.
- bool isConstantInlinedOrAlreadyEmitted(ConstantValue constant) {
- if (constant.isFunction) return true; // Already emitted.
- if (constant.isPrimitive) return true; // Inlined.
- if (constant.isDummy) return true; // Inlined.
- // The name is null when the constant is already a JS constant.
- // TODO(floitsch): every constant should be registered, so that we can
- // share the ones that take up too much space (like some strings).
- if (namer.constantName(constant) == null) return true;
- return false;
- }
-
- // TODO(floitsch): copied from OldEmitter. Adjust or share.
- int compareConstants(ConstantValue a, ConstantValue b) {
- // Inlined constants don't affect the order and sometimes don't even have
- // names.
- int cmp1 = isConstantInlinedOrAlreadyEmitted(a) ? 0 : 1;
- int cmp2 = isConstantInlinedOrAlreadyEmitted(b) ? 0 : 1;
- if (cmp1 + cmp2 < 2) return cmp1 - cmp2;
-
- // Emit constant interceptors first. Constant interceptors for primitives
- // might be used by code that builds other constants. See Issue 18173.
- if (a.isInterceptor != b.isInterceptor) {
- return a.isInterceptor ? -1 : 1;
- }
-
- // Sorting by the long name clusters constants with the same constructor
- // which compresses a tiny bit better.
- int r = namer.constantLongName(a).compareTo(namer.constantLongName(b));
- if (r != 0) return r;
- // Resolve collisions in the long name by using the constant name (i.e. JS
- // name) which is unique.
- return namer.constantName(a).compareTo(namer.constantName(b));
- }
-
- js.Expression generateEmbeddedGlobalAccess(String global) {
- // TODO(floitsch): We should not use "init" for globals.
- return js.string("init.$global");
- }
-
- js.Expression constantReference(ConstantValue value) {
- return _emitter.constantEmitter.reference(value);
- }
-
- void invalidateCaches() {}
-}
« no previous file with comments | « pkg/compiler/lib/src/js_emitter/model.dart ('k') | pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698