Load any URL using Go button in chrome shell.

Load any URL using Go button in chrome shell.

Currently any other link cannot be opened using
Go button in the soft keyboard unless it is in right
format with http://.These changes are to fix the format
of URL in order to open it with Go button.

BUG=429100
Committed: https://crrev.com/131b320fdab62583028e4c0a165262afe5e877cb
Cr-Commit-Position: refs/heads/master@{#302595}

[divya.bansal, 2014-10-31 09:50:15]

divya.bansal@samsung.com changed reviewers:
+ bauerb@chromium.org, tedchoc@chromium.org

[divya.bansal, 2014-10-31 09:50:28]

PTAL

[Ted C, 2014-10-31 17:36:11]

https://codereview.chromium.org/693133002/diff/1/chrome/android/shell/java/sr...
File
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java
(right):

https://codereview.chromium.org/693133002/diff/1/chrome/android/shell/java/sr...
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java:169:
mUrlTextView.getText().toString()));
This is not java indenting.  It should be 8 from the start of the previous line.

And in cases where you have to wrap and the entire contents of the ()s can fit
on the second line, I find it better to wrap that way.

i.e.

Tab tab = mTabManager.openUrl(
        UrlUtilities.fixupUrl(mUrlTextView.getText().toString()));

[divya.bansal, 2014-11-01 05:38:15]

On 2014/10/31 17:36:11, Ted C wrote:
>
https://codereview.chromium.org/693133002/diff/1/chrome/android/shell/java/sr...
> File
>
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java
> (right):
> 
>
https://codereview.chromium.org/693133002/diff/1/chrome/android/shell/java/sr...
>
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java:169:
> mUrlTextView.getText().toString()));
> This is not java indenting.  It should be 8 from the start of the previous
line.
> 
> And in cases where you have to wrap and the entire contents of the ()s can fit
> on the second line, I find it better to wrap that way.
> 
> i.e.
> 
> Tab tab = mTabManager.openUrl(
>         UrlUtilities.fixupUrl(mUrlTextView.getText().toString()));

PTAL

[divya.bansal, 2014-11-03 16:59:31]

On 2014/11/01 05:38:15, divya.bansal wrote:
> On 2014/10/31 17:36:11, Ted C wrote:
> >
>
https://codereview.chromium.org/693133002/diff/1/chrome/android/shell/java/sr...
> > File
> >
>
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java
> > (right):
> > 
> >
>
https://codereview.chromium.org/693133002/diff/1/chrome/android/shell/java/sr...
> >
>
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java:169:
> > mUrlTextView.getText().toString()));
> > This is not java indenting.  It should be 8 from the start of the previous
> line.
> > 
> > And in cases where you have to wrap and the entire contents of the ()s can
fit
> > on the second line, I find it better to wrap that way.
> > 
> > i.e.
> > 
> > Tab tab = mTabManager.openUrl(
> >         UrlUtilities.fixupUrl(mUrlTextView.getText().toString()));
> 
> PTAL

PTAL

[ankitkumar, 2014-11-03 17:27:43]

ankitkumar@chromium.org changed reviewers:
+ ankitkumar@chromium.org

[ankitkumar, 2014-11-03 17:27:44]

https://codereview.chromium.org/693133002/diff/20001/chrome/android/shell/jav...
File
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java
(right):

https://codereview.chromium.org/693133002/diff/20001/chrome/android/shell/jav...
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java:27:
import org.chromium.chrome.browser.TabObserver;
import missing for UrlUtilities
import org.chromium.chrome.browser.UrlUtilities;

[divya.bansal, 2014-11-04 08:54:58]

On 2014/11/03 17:27:44, ankitkumar wrote:
>
https://codereview.chromium.org/693133002/diff/20001/chrome/android/shell/jav...
> File
>
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java
> (right):
> 
>
https://codereview.chromium.org/693133002/diff/20001/chrome/android/shell/jav...
>
chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellToolbar.java:27:
> import org.chromium.chrome.browser.TabObserver;
> import missing for UrlUtilities
> import org.chromium.chrome.browser.UrlUtilities;

PTAL

[Bernhard Bauer, 2014-11-04 09:21:50]

LGTM

FTR, the customary thing is to reply to review comments with something like
"Done" to indicate that you have fixed the pertaining issue (in particular with
big CLs, sometimes you want to fix some of the issues, but continue discussing
others, and it's good to keep track of what has been addressed and what is still
open).

[divya.bansal, 2014-11-04 09:26:18]

On 2014/11/04 09:21:50, Bernhard Bauer wrote:
> LGTM
> 
> FTR, the customary thing is to reply to review comments with something like
> "Done" to indicate that you have fixed the pertaining issue (in particular
with
> big CLs, sometimes you want to fix some of the issues, but continue discussing
> others, and it's good to keep track of what has been addressed and what is
still
> open).

Thanks Bernhard for the suggestion.
I will take care of this in future.

[divya.bansal, 2014-11-04 09:26:32]

The CQ bit was checked by divya.bansal@samsung.com

[commit-bot: I haz the power, 2014-11-04 09:27:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/693133002/40001

[commit-bot: I haz the power, 2014-11-04 10:13:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-11-04 10:13:42]

Patchset 3 (id:??) landed as
https://crrev.com/131b320fdab62583028e4c0a165262afe5e877cb
Cr-Commit-Position: refs/heads/master@{#302595}