Fixed memory leak of FileManagerPrivateApiTest.OnFileChanged.

Fixed memory leak of FileManagerPrivateApiTest.OnFileChanged.

Related CLs:
http://crrev.com/658013002
http://crrev.com/679383002

BUG=423257
TEST=out/Release/browser_tests --gtest_filter=FileManagerPrivateApiTest.OnFileChanged

Committed: https://crrev.com/6ce2a31f4295a155e932e26445c3895f90b784ae
Cr-Commit-Position: refs/heads/master@{#302231}

[yawano, 2014-10-31 05:23:33]

yawano@chromium.org changed reviewers:
+ mtomasz@chromium.org

[yawano, 2014-10-31 05:23:33]

The CL ( http://crrev.com/679383002 ) still has memory leak problem since
destruction tasks are run on FILE thread. I fixed it with this CL. PTAL. Thanks!

[mtomasz, 2014-10-31 05:29:29]

https://codereview.chromium.org/693123002/diff/1/chrome/browser/chromeos/exte...
File
chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc
(right):

https://codereview.chromium.org/693123002/diff/1/chrome/browser/chromeos/exte...
chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc:343:
content::RunAllPendingInMessageLoop(content::BrowserThread::FILE);
Hm. Shall we also wait on the UI message loop? We jump from UI to FILE and then
back to UI thread.

I think we should call:
content::RunAllPendingInMessageLoop(FILE);
base::RunLoop().RunUntilIdle().

What do you think?

[yawano, 2014-10-31 05:39:51]

Thank you for the prompt review! PTAL.

https://codereview.chromium.org/693123002/diff/1/chrome/browser/chromeos/exte...
File
chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc
(right):

https://codereview.chromium.org/693123002/diff/1/chrome/browser/chromeos/exte...
chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc:343:
content::RunAllPendingInMessageLoop(content::BrowserThread::FILE);
On 2014/10/31 05:29:29, mtomasz wrote:
> Hm. Shall we also wait on the UI message loop? We jump from UI to FILE and
then
> back to UI thread.
> 
> I think we should call:
> content::RunAllPendingInMessageLoop(FILE);
> base::RunLoop().RunUntilIdle().
> 
> What do you think?
> 

Yes, it can make the test more stable.
I added a code to wait a message loop of UI thread.

[mtomasz, 2014-10-31 05:46:44]

lgtm

[yawano, 2014-10-31 05:49:41]

The CQ bit was checked by yawano@chromium.org

[commit-bot: I haz the power, 2014-10-31 05:50:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/693123002/40001

[commit-bot: I haz the power, 2014-10-31 06:24:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-31 06:25:35]

Patchset 3 (id:??) landed as
https://crrev.com/6ce2a31f4295a155e932e26445c3895f90b784ae
Cr-Commit-Position: refs/heads/master@{#302231}