Provide a default role for "bubble" windows.

ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h"
 
 #include <X11/extensions/shape.h>
 #include <X11/extensions/XInput2.h>
 #include <X11/Xatom.h>
 #include <X11/Xregion.h>
@@ skipping 1167 matching lines @@
     ui::SetAtomArrayProperty(xwindow_,
                              "_NET_WM_STATE",
                              "ATOM",
                              state_atom_list);
   }
 
   if (!params.wm_class_name.empty() || !params.wm_class_class.empty()) {
     ui::SetWindowClassHint(
         xdisplay_, xwindow_, params.wm_class_name, params.wm_class_class);
   }
-  if (!params.wm_role_name.empty() ||
-      params.type == Widget::InitParams::TYPE_POPUP) {
-    const char kX11WindowRolePopup[] = "popup";
-    ui::SetWindowRole(xdisplay_, xwindow_, params.wm_role_name.empty() ?
-                      std::string(kX11WindowRolePopup) : params.wm_role_name);
+
+  std::string wm_role_name = params.wm_role_name;

[sadrul, 2014/11/03 17:14:03]

Can you use a const char* here instead of making copies/creating std::strings?

[mithro-old, 2014/11/04 05:48:44]

Done.

+  // If the widget isn't overriding the role, provide a default value for popup
+  // and bubble types.
+  if (wm_role_name.empty()) {
+    switch (params.type) {
+      case Widget::InitParams::TYPE_POPUP: {
+        const char kX11WindowRolePopup[] = "popup";
+        wm_role_name = std::string(kX11WindowRolePopup);

[Elliot Glaysher, 2014/10/31 19:42:15]

It should be safe here to just say `wm_role_name = "popup"`.

[mithro-old, 2014/11/04 05:48:44]

Obsolete by sadrul's comments.

+        break;
+      }
+      case Widget::InitParams::TYPE_BUBBLE: {
+        const char kX11WindowRoleBubble[] = "bubble";
+        wm_role_name = std::string(kX11WindowRoleBubble);
+        break;
+      }
+      default:
+        break;
+    }
+  }
+  if (!wm_role_name.empty()) {

[sadrul, 2014/11/03 17:14:03]

No {} for single line blocks

[mithro-old, 2014/11/04 05:48:44]

Done.

+    ui::SetWindowRole(xdisplay_, xwindow_, wm_role_name);
   }
 
   if (params.remove_standard_frame) {
     // Setting _GTK_HIDE_TITLEBAR_WHEN_MAXIMIZED tells gnome-shell to not force
     // fullscreen on the window when it matches the desktop size.
     ui::SetHideTitlebarWhenMaximizedProperty(xwindow_,
                                              ui::HIDE_TITLEBAR_WHEN_MAXIMIZED);
   }
 
   // If we have a parent, record the parent/child relationship. We use this
@@ skipping 740 matching lines @@
   if (linux_ui) {
     ui::NativeTheme* native_theme = linux_ui->GetNativeTheme(window);
     if (native_theme)
       return native_theme;
   }
 
   return ui::NativeTheme::instance();
 }
 
 }  // namespace views