Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Issue 693103003: Files.app: Use the same file type associates as Windows on HTML files. (Closed)

Created:
6 years, 1 month ago by kinaba
Modified:
6 years, 1 month ago
Reviewers:
mtomasz
CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Files.app: Use the same file type associates as Windows on HTML files. This CL associates .xhtm, .xhtml, and .shtml to the browser window. The list matches what Chrome handles on Windows, enumerated at src/chrome/installer/util/shell_util.cc#kDefaultFileAssociations. BUG=427542 Committed: https://crrev.com/e67a5643c6656ecd0347a7cc42371e124fde323d Cr-Commit-Position: refs/heads/master@{#302235}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/chromeos/file_manager/open_with_browser.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_type.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/manifest.json View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
kinaba
PTAL. The reported bug originates from ARC dogfooder group that certain ARC apps becomes a ...
6 years, 1 month ago (2014-10-31 05:59:02 UTC) #2
mtomasz
lgtm
6 years, 1 month ago (2014-10-31 06:08:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693103003/1
6 years, 1 month ago (2014-10-31 06:12:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 06:53:23 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 06:54:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e67a5643c6656ecd0347a7cc42371e124fde323d
Cr-Commit-Position: refs/heads/master@{#302235}

Powered by Google App Engine
This is Rietveld 408576698