Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 693103002: Fixes the mouse click of the search box in the home card. (Closed)

Created:
6 years, 1 month ago by Jun Mukai
Modified:
6 years, 1 month ago
Reviewers:
yoshiki
CC:
chromium-reviews, oshima
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixes the mouse click of the search box in the home card. Minimized background (the black layer) is still "visible" in views point of view even though its layer opacity is 0.0f, and it intercepts mouse/touch events over the actual visible views. It needs to SetVisible(false) when it's not used. BUG=428442 R=yoshiki@chromium.org TEST=manually Committed: https://crrev.com/ab1f170d0c78adbc36ef7716792c434b1b5b30d6 Cr-Commit-Position: refs/heads/master@{#302585}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M athena/home/home_card_impl.cc View 1 6 chunks +18 lines, -1 line 1 comment Download

Messages

Total messages: 10 (2 generated)
Jun Mukai
6 years, 1 month ago (2014-10-31 03:46:45 UTC) #1
Jun Mukai
changing to a local reviewer. yoshiki, could you review this?
6 years, 1 month ago (2014-10-31 05:20:38 UTC) #3
yoshiki
Sorry for late. LGTM.
6 years, 1 month ago (2014-11-04 06:42:22 UTC) #4
yoshiki
https://codereview.chromium.org/693103002/diff/20001/athena/home/home_card_impl.cc File athena/home/home_card_impl.cc (right): https://codereview.chromium.org/693103002/diff/20001/athena/home/home_card_impl.cc#newcode157 athena/home/home_card_impl.cc:157: AddChildView(minimized_background_); Just out of curiosity, why do you add ...
6 years, 1 month ago (2014-11-04 06:49:29 UTC) #5
yoshiki
I'll commit this patch on behalf of mukai, since he is on vacation this week.
6 years, 1 month ago (2014-11-04 06:55:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693103002/20001
6 years, 1 month ago (2014-11-04 06:56:36 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-04 08:00:23 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 08:01:08 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ab1f170d0c78adbc36ef7716792c434b1b5b30d6
Cr-Commit-Position: refs/heads/master@{#302585}

Powered by Google App Engine
This is Rietveld 408576698